Skip to contentSkip to conversation

xen: Make serial console work

PATCH In review Christoph Egger 2 participants 3 messages Jun 4, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen: Make serial console work

Hi!

Attached patch makes serial console work in simulators which don't emulate an ns16550a but an ns16450.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xen/drivers/char/ns16550.c +1 -1
diff -r 9881884f8834 xen/drivers/char/ns16550.c
@@ -408,7 +408,7 @@ static int __init check_existence(struct
      */
     ns_write_reg(uart, MCR, MCR_LOOP | 0x0A);
     status = ns_read_reg(uart, MSR) & 0xF0;
-    return (status == 0x90);
+    return (status == 0x90 || status == 0x30);
 }
 
 #define PARSE_ERR(_f, _a...)                 \

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 5 lines · Christoph Egger

Hi!

Attached patch makes serial console work in simulators which don't emulate an ns16550a but an ns16450.

I didn't think MCR and MSR registers had different behaviour between 16450 and 16550? Is the emulator simply dodgy?

-- Keir

Quoted 1 line
#2 lore raw
Quoted 10 lines · Keir Fraser
Quoted 5 lines · Christoph Egger

Hi!

Attached patch makes serial console work in simulators which don't emulate an ns16550a but an ns16450.

I didn't think MCR and MSR registers had different behaviour between 16450 and 16550? Is the emulator simply dodgy?

Yeah, I see that Linux's 8250 code has the same test. I think the emulator is what needs fixing.

-- Keir

Quoted 10 lines

-- Keir

Quoted 1 line

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel