Skip to contentSkip to conversation

xkeyboard-config: Depends on intltool

PATCH New Paul Jones 2 participants 3 messages May 22, 2010 – Jun 5, 2010

lore
Share & tools
lore

Paul Jones

author
#0 lore raw

PATCH 1/1 xkeyboard-config: Depends on intltool

Sorry for sending this as an attachment but git send-email wasn't making it to the list.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100522/262ed7c9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xkeyboard-config-Depends-on-intltool.patch
Type: application/octet-stream
Size: 1418 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100522/262ed7c9/attachment-0001.obj>

#1 lore raw

PATCH 1/1 xkeyboard-config: Depends on intltool

Hello Paul,

I still think this is wrong. intltool is required on the host, no on the target. So:

* There should be no modification in the Config.in file

* The dependency in the .mk should be on host-intltool instead

Cheers,

Thomas

Quoted 24 lines · On Sat, 22 May 2010 16:54:27 +1000 "Paul Jones" <[email protected]> wrote:
package/x11r7/xkeyboard-config/Config.in +1 -0
index 8e27dac..a84679c 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_XKEYBOARD_CONFIG
 	bool "xkeyboard-config"
 	select BR2_PACKAGE_XAPP_XKBCOMP
+	select BR2_PACKAGE_INTLTOOL
 	help
 	  keyboard configuration database for X
package/x11r7/xkeyboard-config/xkeyboard-config.mk +1 -0
index 9c9c8b5..3cbfba2 100644
@@ -10,6 +10,7 @@ XKEYBOARD_CONFIG_AUTORECONF = NO
 XKEYBOARD_CONFIG_INSTALL_STAGING = NO
 XKEYBOARD_CONFIG_INSTALL_TARGET = YES
 XKEYBOARD_CONFIG_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
+XKEYBOARD_CONFIG_DEPENDENCIES = intltool
 
 XKEYBOARD_CONFIG_CONF_OPT = GMSGFMT=/usr/bin/msgfmt
Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 xkeyboard-config: Depends on intltool

Quoted 10 lines

-----Original Message-----
From: buildroot-bounces at busybox.net [mailto:buildroot- bounces at busybox.net] On Behalf Of Thomas Petazzoni
Sent: Sunday, 6 June 2010 1:31 AM
To: buildroot at busybox.net
Subject: Re: [Buildroot] [PATCH] xkeyboard-config: Depends on intltool

Hello Paul,

I still think this is wrong. intltool is required on the host, no on

the target. So:

Quoted 4 lines

* There should be no modification in the Config.in file

* The dependency in the .mk should be on host-intltool instead

Yes, you're right. On further investigation I think what happened was I tested the patch on a different system without realising. Depending on where I am and what I'm doing I use either Ubuntu or Gentoo build hosts. The problem occurred on Ubuntu so I made that patch but I tested it later on the Gentoo system which has intltool already so it looked like I fixed the problem.

I've modified the patch and tested it on the right system this time...

Regards,
Paul.