Skip to contentSkip to conversation

OMAP: GPIO: fix auto-disable of debounce clock

PATCH In review Kevin Hilman 3 participants 3 messages Jun 2, 2010 – Jun 7, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP: GPIO: fix auto-disable of debounce clock

The addition of the new debounce code (commit 168ef3d9a56bd8bffe0ef4189c450888b4aefefe) broke the auto-disable of debounce clocks on idle by forgetting to update the debounce clock enable mask.

Add back the updating of bank->dbck_enable_mask so debounce clocks are auto-disabled.

---
Please include for 2.6.35-rc series.

 arch/arm/plat-omap/gpio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-omap/gpio.c +1 -0
index 393e921..9b7e354 100644
@@ -673,6 +673,7 @@ static void _set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
 		if (cpu_is_omap34xx() || cpu_is_omap44xx())
 			clk_disable(bank->dbck);
 	}
+	bank->dbck_enable_mask = val;
 
 	__raw_writel(val, reg);
 }
Signature · 1 line
1.7.0.2
#1 lore raw

PATCH 1/1 OMAP: GPIO: fix auto-disable of debounce clock

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 0b703473c328c991acf2366f4ebefc8d38884799

PatchWorks
http://patchwork.kernel.org/patch/103831/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=0b703473c328c991acf2366f4ebefc8d38884799

#2 lore raw
In reply to Kevin Hilman
Quoted 11 lines · ext Kevin Hilman

The addition of the new debounce code (commit 168ef3d9a56bd8bffe0ef4189c450888b4aefefe) broke the auto-disable of debounce clocks on idle by forgetting to update the debounce clock enable mask.

Add back the updating of bank->dbck_enable_mask so debounce clocks are auto-disabled.

---
Please include for 2.6.35-rc series.

oops, my bad :-(

Signature · 3 lines
balbi

DefectiveByDesign.org