Skip to contentSkip to conversation

powerpc/85xx: Fix booting for P1021MDS boards

PATCH Applied Anton Vorontsov 2 participants 2 messages Jun 8, 2010 – Aug 4, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 powerpc/85xx: Fix booting for P1021MDS boards

P1021 processors have no dedicated ROM to store the QE microcode, so the fimrware is stored externally, and it is U-Boot responsibility to load it. It might be that the board is booting without QE, e.g. currently U-Boot doesn't support QE for P1021MDS boards, which means that QE isn't initialized, and so the board hangs early at boot.

This patch fixes the issue by marking QE as disabled and checking the state in the probing code. U-Boot should fixup the state if it initialized the QE.

---
 arch/powerpc/boot/dts/p1021mds.dts        |    1 +
 arch/powerpc/platforms/85xx/mpc85xx_mds.c |   43 +++++++++++++++++++++++++----
 2 files changed, 38 insertions(+), 6 deletions(-)
arch/powerpc/boot/dts/p1021mds.dts +1 -0
index 7fad2df..ad5b852 100644
@@ -617,6 +617,7 @@
 		bus-frequency = <0>;
 		fsl,qe-num-riscs = <1>;
 		fsl,qe-num-snums = <28>;
+		status = "disabled"; /* no firmware loaded */
 
 		qeic: interrupt-controller@80 {
 			interrupt-controller;
arch/powerpc/platforms/85xx/mpc85xx_mds.c +37 -6

93 lines not on this page · raw message

Signature · 1 line
1.7.0.5
Applied
#1 lore raw
Quoted 10 lines · Anton Vorontsov

P1021 processors have no dedicated ROM to store the QE microcode, so the fimrware is stored externally, and it is U-Boot responsibility to load it. It might be that the board is booting without QE, e.g. currently U-Boot doesn't support QE for P1021MDS boards, which means that QE isn't initialized, and so the board hangs early at boot. =20
This patch fixes the issue by marking QE as disabled and checking the state in the probing code. U-Boot should fixup the state if it initialized the QE.
=20

Quoted 4 lines

---
arch/powerpc/boot/dts/p1021mds.dts | 1 +
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 43 =

+++++++++++++++++++++++++----

Quoted 1 line
2 files changed, 38 insertions(+), 6 deletions(-)

applied to next

- k=