ocfs2: Limit default local alloc size within bitmap range.
PATCH 1/1 ocfs2: Limit default local alloc size within bitmap range.
In commit 6b82021b9e91cd689fdffadbcdb9a42597bbe764, we increase our local alloc size and calculate how much megabytes we can get according to group size and volume size.
But we also need to check the maximum bits a local alloc block bitmap can have. With a bs=512, cs=32K, local volume with 160G, it calculate 96MB while the maximum local alloc size is only 76M. So the bitmap will overflow and corrupt the system truncate log file. See bug
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1262
--- fs/ocfs2/localalloc.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
fs/ocfs2/localalloc.c +7 -0
@@ -118,6 +118,7 @@ unsigned int ocfs2_la_default_mb(struct ocfs2_super *osb) {unsigned int la_mb;unsigned int gd_mb; +unsigned int la_max_mb;unsigned int megs_per_slot;struct super_block *sb = osb->sb;
@@ -182,6 +183,12 @@ unsigned int ocfs2_la_default_mb(struct ocfs2_super *osb)if (megs_per_slot < la_mb) la_mb = megs_per_slot; +/* We can't store more bits than we can in a block. */ + la_max_mb =ocfs2_clusters_to_megabytes (osb->sb, +ocfs2_local_alloc_size (sb) *8 ); +if (la_mb > la_max_mb) + la_mb = la_max_mb; +return la_mb; }
Signature · 1 line
1.5.5
PATCH 1/1 ocfs2: Limit default local alloc size within bitmap range.
Quoted 41 lines · Tao Ma
In commit
6b82021b9e91cd689fdffadbcdb9a42597bbe764, we increase our local alloc size and calculate how much megabytes we can get according to group size and volume size.
But we also need to check the maximum bits a local alloc block bitmap can have. With a bs=512, cs=32K, local volume with 160G, it calculate 96MB while the maximum local alloc size is only 76M. So the bitmap will overflow and corrupt the system truncate log file. See bug
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1262Cc Mark Fasheh <[email protected]>Signed-off-by Tao Ma <[email protected]>--- fs/ocfs2/localalloc.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)fs/ocfs2/localalloc.c +7
-0@@ -118,6 +118,7 @@ unsigned int ocfs2_la_default_mb(struct ocfs2_super *osb) {unsigned int la_mb;unsigned int gd_mb; +unsigned int la_max_mb;unsigned int megs_per_slot;struct super_block *sb = osb->sb;@@ -182,6 +183,12 @@ unsigned int ocfs2_la_default_mb(struct ocfs2_super *osb)if (megs_per_slot < la_mb) la_mb = megs_per_slot; +/* We can't store more bits than we can in a block. */ + la_max_mb =ocfs2_clusters_to_megabytes (osb->sb, +ocfs2_local_alloc_size (sb) *8 ); +if (la_mb > la_max_mb) + la_mb = la_max_mb; +return la_mb; }
PATCH 1/1 ocfs2: Limit default local alloc size within bitmap range.
In reply to Tao MaQuoted 10 lines · Tao Ma
In commit
6b82021b9e91cd689fdffadbcdb9a42597bbe764, we increase our local alloc size and calculate how much megabytes we can get according to group size and volume size.
But we also need to check the maximum bits a local alloc block bitmap can have. With a bs=512, cs=32K, local volume with 160G, it calculate 96MB while the maximum local alloc size is only 76M. So the bitmap will overflow and corrupt the system truncate log file. See bug
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1262
--Mark
--
Mark Fasheh
PATCH 1/1 ocfs2: Limit default local alloc size within bitmap range.
In reply to Tao MaQuoted 10 lines · Tao Ma
In commit
6b82021b9e91cd689fdffadbcdb9a42597bbe764, we increase our local alloc size and calculate how much megabytes we can get according to group size and volume size.
But we also need to check the maximum bits a local alloc block bitmap can have. With a bs=512, cs=32K, local volume with 160G, it calculate 96MB while the maximum local alloc size is only 76M. So the bitmap will overflow and corrupt the system truncate log file. See bug
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1262
Quoted 2 lines
Cc Mark Fasheh <[email protected]>Signed-off-by Tao Ma <[email protected]>
This patch is now in the 'fixes' branch of ocfs2.git.
Joel
Signature · 9 lines
"The question of whether computers can think is just like the question of whether submarines can swim." - Edsger W. Dijkstra Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127