Skip to contentSkip to conversation

be2iscsi: null dereference on error path

PATCH In review Dan Carpenter 2 participants 2 messages Jun 10, 2010

Subsystems (3)
SCSI Kernel janitors Emulex 10Gbps iSCSI - OneConnect driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/2 be2iscsi: null dereference on error path

"phba" is always null here so we can't dereference it.

Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/be2iscsi/be_main.c +2 -2
index 779e1d1..efadde9 100644
@@ -3774,8 +3774,8 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev,
 
 	ret = beiscsi_enable_pci(pcidev);
 	if (ret < 0) {
-		shost_printk(KERN_ERR, phba->shost, "beiscsi_dev_probe-"
-			     "Failed to enable pci device \n");
+		dev_err(&pcidev->dev, "beiscsi_dev_probe-"
+			" Failed to enable pci device\n");
 		return ret;
 	}
Reviewed-by on v1 2/2
#1 lore raw
Quoted 9 lines · Dan Carpenter

"phba" is always null here so we can't dereference it.

Signed-off-by Dan Carpenter<[email protected]>
drivers/scsi/be2iscsi/be_main.c +0 -0
index 779e1d1..efadde9 100644

drivers/scsi/be2iscsi/be_main.c static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev, · line 3781

Quoted 10 lines
drivers/scsi/be2iscsi/be_main.c +2 -2
@@ -3774,8 +3774,8 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev,
 
  	ret = beiscsi_enable_pci(pcidev);
  	if (ret<  0) {
-		shost_printk(KERN_ERR, phba->shost, "beiscsi_dev_probe-"
-			     "Failed to enable pci device \n");
+		dev_err(&pcidev->dev, "beiscsi_dev_probe-"
+			" Failed to enable pci device\n");
  		return ret;
  	}

Looks good. Thanks.

Reviewed-by Mike Christie <[email protected]>