s5pc110: SDHCI-s3c can override host capabilities

PATCH New Kyungmin Park 2 participants 3 messages Jun 5, 2010 – Jun 10, 2010

Subsystems (3)

Arm (32-bit) Arm sub-architectures MMC, SD and SDIO

lore

Share & tools

lore

Kyungmin Park

author

2010-06-05 02:40 UTC #0 lore raw

PATCH 1/1 s5pc110: SDHCI-s3c can override host capabilities

Each board can override the default sdhci host capabilities. Some board has broken features by hardwares and support 8-bit bandwidth.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/plat-samsung/dev-hsmmc.c +2 -0

index 4c05b39..d0887da 100644
@@ -65,4 +65,6 @@ void s3c_sdhci0_set_platdata(struct s3c_sdhci_platdata *pd)
 		set->cfg_gpio = pd->cfg_gpio;
 	if (pd->cfg_card)
 		set->cfg_card = pd->cfg_card;
+	if (pd->host_caps)
+		set->host_caps = pd->host_caps;
 }

arch/arm/plat-samsung/dev-hsmmc1.c +2 -0

index e49bc4c..e45a82e 100644
@@ -65,4 +65,6 @@ void s3c_sdhci1_set_platdata(struct s3c_sdhci_platdata *pd)
 		set->cfg_gpio = pd->cfg_gpio;
 	if (pd->cfg_card)
 		set->cfg_card = pd->cfg_card;
+	if (pd->host_caps)
+		set->host_caps = pd->host_caps;
 }

arch/arm/plat-samsung/dev-hsmmc2.c +2 -0

index 824580b..5ee3b89 100644
@@ -66,4 +66,6 @@ void s3c_sdhci2_set_platdata(struct s3c_sdhci_platdata *pd)
 		set->cfg_gpio = pd->cfg_gpio;
 	if (pd->cfg_card)
 		set->cfg_card = pd->cfg_card;
+	if (pd->host_caps)
+		set->host_caps = pd->host_caps;
 }

Andrew Morton

2010-06-10 20:43 UTC #1 lore raw

PATCH 1/1 s5pc110: SDHCI-s3c can override host capabilities

Quoted 10 lines · On Sat, 05 Jun 2010 11:40:53 +0900 Kyungmin Park <[email protected]> wrote:

From: Kyungmin Park <[email protected]>
To: linux-arm-kernel at lists.infradead.org, linux-mmc at vger.kernel.org, akpm at linux-foundation.org, ben-linux at fluff.org
Subject: [PATCH] s5pc110: SDHCI-s3c can override host capabilities
Date: Sat, 05 Jun 2010 11:40:53 +0900
User-Agent: Mutt/1.5.14 (2007-02-12)
Each board can override the default sdhci host capabilities. Some board has broken features by hardwares and support 8-bit bandwidth.
Signed-off-by Kyungmin Park <[email protected]>

The way this patch was presented, it will go into git with an Author:
address of "kmpark at infradead.org", but a Signed-off-by: address of "kyungmin.park at samsung.com". Which is a little odd.

The way to prevent that is to put an explicit "From:" line at the top of the changelog. If that line is absent, people's tools will fall back to the From: line in the mail headers, which is what happened here.

Please let me know if you want me to make any changes to these three patches.

Kyungmin Park

author

2010-06-10 23:06 UTC #2 lore raw

PATCH 1/1 s5pc110: SDHCI-s3c can override host capabilities

hi,

Quoted 18 lines · Andrew Morton

Quoted 10 lines · On Sat, 05 Jun 2010 11:40:53 +0900 Kyungmin Park <[email protected]> wrote:
From: Kyungmin Park <[email protected]>
To: linux-arm-kernel at lists.infradead.org, linux-mmc at vger.kernel.org, akpm at linux-foundation.org, ben-linux at fluff.org
Subject: [PATCH] s5pc110: SDHCI-s3c can override host capabilities
Date: Sat, 05 Jun 2010 11:40:53 +0900
User-Agent: Mutt/1.5.14 (2007-02-12)
Each board can override the default sdhci host capabilities. Some board has broken features by hardwares and support 8-bit bandwidth.
Signed-off-by Kyungmin Park <[email protected]>
The way this patch was presented, it will go into git with an Author:
address of "kmpark at infradead.org", but a Signed-off-by: address of "kyungmin.park at samsung.com". ?Which is a little odd.

Quoted 8 lines

The way to prevent that is to put an explicit "From:" line at the top of the changelog. ?If that line is absent, people's tools will fall back to the From: line in the mail headers, which is what happened here.
Please let me know if you want me to make any changes to these three patches.

No problem, please fix it freely.

Next time, I'll add the From line.
One more, mails from Marek has duplicated patches, so please ignore it.

Thank you,
Kyungmin Park