Skip to contentSkip to conversation

hpsa: fix use of uninitialized variable in hpsa_add_msa2xxx_enclosure_device()

PATCH New Stephen M. Cameron 1 participant 1 message Jun 11, 2010

Subsystems (2)
SCSI Hewlett-packard smart array RAID driver (hpsa)
lore
Share & tools
lore

Stephen M. Cameron

author
#0 lore raw

PATCH 1/1 hpsa: fix use of uninitialized variable in hpsa_add_msa2xxx_enclosure_device()

From: Stephen M. Cameron <[email protected]>

hpsa: fix use of uninitialized variable in hpsa_add_msa2xxx_enclosure_device()

Signed-off-by Stephen M. Cameron <[email protected]>
---
 drivers/scsi/hpsa.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/hpsa.c +2 -2
index 2c75f68..52fe4ee 100644
@@ -1595,6 +1595,8 @@ static int add_msa2xxx_enclosure_device(struct ctlr_info *h,
 	if (lun == 0) /* if lun is 0, then obviously we have a lun 0. */
 		return 0;
 
+	memset(scsi3addr, 0, 8);
+	scsi3addr[3] = target;
 	if (is_hba_lunid(scsi3addr))
 		return 0; /* Don't add the RAID controller here. */
 

@@ -1609,8 +1611,6 @@ static int add_msa2xxx_enclosure_device(struct ctlr_info *h,
 		return 0;
 	}
 
-	memset(scsi3addr, 0, 8);
-	scsi3addr[3] = target;
 	if (hpsa_update_device_info(h, scsi3addr, this_device))
 		return 0;
 	(*nmsa2xxx_enclosures)++;