Skip to contentSkip to conversation

UBI: initialise update marker

PATCH New Kyungmin Park 2 participants 2 messages Jun 12, 2010 – Jun 22, 2010

Subsystems (2)
Memory technology devices (MTD) Unsorted block images (UBI)
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 UBI: initialise update marker

From: Peter Horton <[email protected]>

UBI: initialise update marker

The in kernel copy of a volume's update marker is not initialised from the volume table. This means that volumes where an update was unfinnished will not be treated as "forbidden to use". This is basically that the update functionality was broken.

Signed-off-by Peter Horton <[email protected]>
Signed-off-by Artem Bityutskiy <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---

drivers/mtd/ubi/vtbl.c +1 -0
index 1afc61e..4004402 100644
@@ -566,6 +566,7 @@ static int init_volumes(struct ubi_device *ubi, const struct ubi_scan_info *si,
 		vol->reserved_pebs = be32_to_cpu(vtbl[i].reserved_pebs);
 		vol->alignment = be32_to_cpu(vtbl[i].alignment);
 		vol->data_pad = be32_to_cpu(vtbl[i].data_pad);
+		vol->upd_marker = vtbl[i].upd_marker;
 		vol->vol_type = vtbl[i].vol_type == UBI_VID_DYNAMIC ?
 					UBI_DYNAMIC_VOLUME : UBI_STATIC_VOLUME;
 		vol->name_len = be16_to_cpu(vtbl[i].name_len);
Applied
#1 lore raw

PATCH 1/1 UBI: initialise update marker

Dear Kyungmin Park,

Quoted 4 lines · In message <20100612011156.GA23405@july> you wrote:

From: Peter Horton <[email protected]>

UBI: initialise update marker

Quoted 8 lines

The in kernel copy of a volume's update marker is not initialised from the volume table. This means that volumes where an update was unfinnished will not be treated as "forbidden to use". This is basically that the update functionality was broken.

Signed-off-by Peter Horton <[email protected]>
Signed-off-by Artem Bityutskiy <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I've got a bad feeling about this.