Skip to contentSkip to conversation

checkpatch.pl skip long lines

PATCH In review Fredrik Gustafsson 3 participants 4 messages Jun 12, 2010 – Jun 13, 2010 Checkpatch

lore
Share & tools
lore

Fredrik Gustafsson

author
#0 lore raw

PATCH 1/1 checkpatch.pl skip long lines

Hi,
since the number of long lines in the linux kernel is huge and since Greg Kroah Hartman in his google tech talk about the kernel
(http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably ignore that criteria in the future, I thought the checkpatch.pl script should have an option to ignore checking for long lines.

This would help finding the real errors and warnings, because they don't drown in line length warnings.

--
Regards
iveqy

Quoted 1 line

From ce6f2138969a56f5cbde2948f239c5204f0cafe1 Mon Sep 17 00:00:00 2001

From: iveqy <[email protected]>
Date: Sat, 12 Jun 2010 18:57:51 +0200
Subject: [PATCH] Add skiplinelength parameter

---
 scripts/checkpatch.pl |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)
scripts/checkpatch.pl +10 -6
index bd88f11..e0683f4 100755
@@ -29,6 +29,7 @@ my $summary_file = 0;
 my $root;
 my %debug;
 my $help = 0;
+my $skip_line_length = 0;
 
 sub help {
 	my ($exitcode) = @_;

@@ -49,6 +50,7 @@ Options:
   --root=PATH                PATH to the kernel tree root
   --no-summary               suppress the per-file summary
   --mailback                 only produce a report in case of warnings/errors
+  --skiplinelength           skip check for long lines
   --summary-file             include the filename in summary
   --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
                              'values', 'possible', 'type', and 'attr' (default

@@ -81,6 +83,7 @@ GetOptions(
 	'debug=s'	=> \%debug,
 	'test-only=s'	=> \$tst_only,
 	'h|help'	=> \$help,
+	'skiplinelength!'	=> \$skip_line_length,
 	'version'	=> \$help
 ) or help(1);
 

@@ -1401,12 +1404,13 @@ sub process {
 		next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
 
 #80 column limit
-		if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
-		    $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
-		    $line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
-		    $length > 80)
-		{
-			WARN("line over 80 characters\n" . $herecurr);
+		if(!$skip_line_length) {
+			if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
+				$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
+				$line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
+				$length > 80) {
+				WARN("line over 80 characters\n" . $herecurr);
+			}
 		}
 
 # check for spaces before a quoted newline
Signature · 1 line
1.6.4.4
#1 lore raw
Quoted 8 lines · Fredrik Gustafsson

since the number of long lines in the linux kernel is huge and since Greg Kroah Hartman in his google tech talk about the kernel
(http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably ignore that criteria in the future, I thought the checkpatch.pl script should have an option to ignore checking for long lines.

This would help finding the real errors and warnings, because they don't drown in line length warnings.

Instead of adding another command-line option, I'd suggest to just use CHK instead of WARN, so this check will be enabled with --strict. I wonder if there is already consensus on deprecating the 80-char-rule?

Regards,

Wolfram

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
maintainer
#2 lore raw
Quoted 8 lines · Wolfram Sang
Quoted 6 lines · Fredrik Gustafsson

since the number of long lines in the linux kernel is huge and since Greg Kroah Hartman in his google tech talk about the kernel
(http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably ignore that criteria in the future, I thought the checkpatch.pl script should have an option to ignore checking for long lines.

Quoted 6 lines
Quoted 2 lines

This would help finding the real errors and warnings, because they don't drown in line length warnings.

Instead of adding another command-line option, I'd suggest to just use CHK instead of WARN, so this check will be enabled with --strict. I wonder if there is already consensus on deprecating the 80-char-rule?

Nope. There's a vocal contingent that doesn't like it though. An earlier thread and suggested patch below.
http://lkml.org/lkml/2009/12/18/3

#3 lore raw
Quoted 7 lines
Quoted 3 lines

Instead of adding another command-line option, I'd suggest to just use CHK instead of WARN, so this check will be enabled with --strict. I wonder if there is already consensus on deprecating the 80-char-rule?

Nope. There's a vocal contingent that doesn't like it though. An earlier thread and suggested patch below.
http://lkml.org/lkml/2009/12/18/3

Thought so. I like your approach, missed it back then. I'd vote for 132 chars as the next limit, though.

Regards,

Wolfram

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |