Skip to contentSkip to conversation

hid: ignore digitizer usage Undefined (0x00)

PATCH In review Forest Bond 2 participants 5 messages May 27, 2010 – Jul 14, 2010 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hid: ignore digitizer usage Undefined (0x00)

SMART Technologies has recommended this change to fix a problem reported with SMART Board series interactive whiteboards.

A description of the device-specific symptom follows:

When the board is connected my mouse bounces up to the top left corner.

Bjorn has tested this fix with model SB680.

---
 drivers/hid/hid-input.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/hid/hid-input.c +3 -0
index 7a0d2e4..6b10e5a 100644
@@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	case HID_UP_DIGITIZER:
 		switch (usage->hid & 0xff) {
+		case 0x00: /* Undefined */
+			goto ignore;
+
 		case 0x30: /* TipPressure */
 			if (!test_bit(BTN_TOUCH, input->keybit)) {
 				device->quirks |= HID_QUIRK_NOTOUCH;
Signature · 1 line
1.7.0.4
#1 lore raw

Hi,

I'm not sure if anyone noticed this patch. Did I send it to the right place?

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
Quoted 31 lines · Forest Bond

SMART Technologies has recommended this change to fix a problem reported with SMART Board series interactive whiteboards.

A description of the device-specific symptom follows:

When the board is connected my mouse bounces up to the top left corner.

Bjorn has tested this fix with model SB680.

---
 drivers/hid/hid-input.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/hid/hid-input.c +3 -0
index 7a0d2e4..6b10e5a 100644
@@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	case HID_UP_DIGITIZER:
 		switch (usage->hid & 0xff) {
+		case 0x00: /* Undefined */
+			goto ignore;
+
 		case 0x30: /* TipPressure */
 			if (!test_bit(BTN_TOUCH, input->keybit)) {
 				device->quirks |= HID_QUIRK_NOTOUCH;
Signature · 1 line
1.7.0.4
#2 lore raw
In reply to Forest Bond

Hi Jiri,

This patch has gone ignored on the linux-input mailing list. Perhaps that was done intentionally, but I wanted to try once more to get it looked at before giving up.

Can you comment?

Thanks,
Forest

Quoted 31 lines · Forest Bond

SMART Technologies has recommended this change to fix a problem reported with SMART Board series interactive whiteboards.

A description of the device-specific symptom follows:

When the board is connected my mouse bounces up to the top left corner.

Bjorn has tested this fix with model SB680.

---
 drivers/hid/hid-input.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/hid/hid-input.c +3 -0
index 7a0d2e4..6b10e5a 100644
@@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	case HID_UP_DIGITIZER:
 		switch (usage->hid & 0xff) {
+		case 0x00: /* Undefined */
+			goto ignore;
+
 		case 0x30: /* TipPressure */
 			if (!test_bit(BTN_TOUCH, input->keybit)) {
 				device->quirks |= HID_QUIRK_NOTOUCH;
Signature · 1 line
1.7.0.4
#3 lore raw
In reply to Forest Bond
Quoted 20 lines · Forest Bond

SMART Technologies has recommended this change to fix a problem reported with SMART Board series interactive whiteboards.

A description of the device-specific symptom follows:

When the board is connected my mouse bounces up to the top left corner.

Bjorn has tested this fix with model SB680.

---
 drivers/hid/hid-input.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/hid/hid-input.c +0 -0
index 7a0d2e4..6b10e5a 100644

drivers/hid/hid-input.c static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel · line 309

Quoted 9 lines
drivers/hid/hid-input.c +3 -0
@@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	case HID_UP_DIGITIZER:
 		switch (usage->hid & 0xff) {
+		case 0x00: /* Undefined */
+			goto ignore;
+
 		case 0x30: /* TipPressure */
 			if (!test_bit(BTN_TOUCH, input->keybit)) {
 				device->quirks |= HID_QUIRK_NOTOUCH;

Hi,

I have applied the patch as it makes sense per se.

Still, I'd be interested to know what is the device in question actually sending and what it has in its report descriptor. Does it indeed use 0x00 code? For what reason?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#4 lore raw

Hi Jiri,

Quoted 33 lines · Jiri Kosina
Quoted 20 lines · Forest Bond

SMART Technologies has recommended this change to fix a problem reported with SMART Board series interactive whiteboards.

A description of the device-specific symptom follows:

When the board is connected my mouse bounces up to the top left corner.

Bjorn has tested this fix with model SB680.

---
 drivers/hid/hid-input.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/hid/hid-input.c +0 -0
index 7a0d2e4..6b10e5a 100644

drivers/hid/hid-input.c static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel · line 309

Quoted 9 lines
drivers/hid/hid-input.c +3 -0
@@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	case HID_UP_DIGITIZER:
 		switch (usage->hid & 0xff) {
+		case 0x00: /* Undefined */
+			goto ignore;
+
 		case 0x30: /* TipPressure */
 			if (!test_bit(BTN_TOUCH, input->keybit)) {
 				device->quirks |= HID_QUIRK_NOTOUCH;

Hi,

Quoted 1 line

I have applied the patch as it makes sense per se.

Thanks! I hope your holiday was pleasant.

Quoted 3 lines

Still, I'd be interested to know what is the device in question actually sending and what it has in its report descriptor. Does it indeed use 0x00 code? For what reason?

I wish I could answer that for you. I don't really know much about the device (I haven't actually seen one myself).

I'll try to request more information from the manufacturer.

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org