Skip to contentSkip to conversation

smatch stuff: fnic: VNIC_FNIC_EDTOV_MAX is too high.

DISCUSSION Dan Carpenter 1 participant 1 message Jun 14, 2010 SCSI

lore
Share & tools
lore
#0 lore raw

This is a smatch thing. Neither VNIC_FNIC_EDTOV_MAX nor VNIC_FNIC_RATOV_MAX do anything. They are both set to 255000 but ed_tov and ra_tov are u16 so they can't go higher than 65535.

drivers/scsi/fnic/fnic_res.c

    95          c->ed_tov =
    96                  min_t(u32, VNIC_FNIC_EDTOV_MAX,
    97                        max_t(u32, VNIC_FNIC_EDTOV_MIN,
    98                              c->ed_tov));
    99

100 c->ra_tov =
101 min_t(u32, VNIC_FNIC_RATOV_MAX,
102 max_t(u32, VNIC_FNIC_RATOV_MIN,
103 c->ra_tov));

regards,
dan carpenter