Skip to contentSkip to conversation

option to define path to custom rootfs skeleton

PATCH New Dmytro Milinevskyy 2 participants 3 messages Jun 10, 2010 – Jun 15, 2010

Subsystems (2)
VFS Kbuild
lore
Share & tools
lore

Dmytro Milinevskyy

author
#0 lore raw

PATCH 2/2 option to define path to custom rootfs skeleton

Signed-off-by Dmytro Milinevskyy <[email protected]>
---
 Makefile     |    4 ++++
 fs/Config.in |   24 ++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)
Makefile +4 -0
index 1b5cdd4..67110f1 100644
@@ -378,6 +378,10 @@ endif
 	@mkdir -p $(STAGING_DIR)/usr/include
 	@mkdir -p $(STAGING_DIR)/usr/bin
 
+ifeq ($(BR2_ROOTFS_SKELETON_CUSTOM),y)
+TARGET_SKELETON=$(BR2_ROOTFS_SKELETON_CUSTOM_PATH)
+endif
+
 $(BUILD_DIR)/.root:
 	mkdir -p $(TARGET_DIR)
 	if ! [ -d "$(TARGET_DIR)/bin" ]; then \
fs/Config.in +24 -0
index 6865eea..2163890 100644
@@ -23,6 +23,30 @@ config BR2_ROOTFS_DEVICE_TABLE
          to the makedevs utility to create all the special device
          files in the target filesystem.
 
+choice
+	prompt "Root FS skeleton"
+
+	config BR2_ROOTFS_SKELETON_DEFAULT
+		bool "default target skeleton"
+        help
+          Use default target skeleton
+
+	config BR2_ROOTFS_SKELETON_CUSTOM
+		bool "custom target skeleton"
+		help
+	  	 Use custom target skeleton.
+
+endchoice
+
+if BR2_ROOTFS_SKELETON_CUSTOM
+	config BR2_ROOTFS_SKELETON_CUSTOM_PATH
+		string "custom target skeleton path"
+        default "fs/skeleton"
+		help
+	  	 Path custom target skeleton.
+endif
+
+
 source "fs/cramfs/Config.in"
 source "fs/cloop/Config.in"
 source "fs/ext2/Config.in"
Signature · 1 line
1.7.1
#1 lore raw

PATCH 2/2 option to define path to custom rootfs skeleton

Hello,

Quoted 21 lines · On Thu, 10 Jun 2010 22:58:40 +0300 Dmytro Milinevskyy <[email protected]>…

index 6865eea..2163890 100644

fs/Config.in +14 -0
@@ -23,6 +23,30 @@ config BR2_ROOTFS_DEVICE_TABLE
          to the makedevs utility to create all the special device
          files in the target filesystem.
 
+choice
+	prompt "Root FS skeleton"
+
+	config BR2_ROOTFS_SKELETON_DEFAULT
+		bool "default target skeleton"
+        help
+          Use default target skeleton
+
+	config BR2_ROOTFS_SKELETON_CUSTOM
+		bool "custom target skeleton"
+		help
+	  	 Use custom target skeleton.
+
+endchoice

fs/Config.in config BR2_ROOTFS_DEVICE_TABLE · line 49

Quoted 10 lines
fs/Config.in +10 -0
+
+if BR2_ROOTFS_SKELETON_CUSTOM
+	config BR2_ROOTFS_SKELETON_CUSTOM_PATH
+		string "custom target skeleton path"
+        default "fs/skeleton"
+		help
+	  	 Path custom target skeleton.
+endif
+
+

You have indentation issues here. It should be:

choice
prompt "Root FS skeleton"

config BR2_ROOTFS_SKELETON_DEFAULT
bool "default target skeleton"
help
Use default target skeleton

config BR2_ROOTFS_SKELETON_CUSTOM
bool "custom target skeleton"
help
Use custom target skeleton

endchoice

if BR2_ROOTFS_SKELETON_CUSTOM

config BR2_ROOTFS_SKELETON_CUSTOM_PATH
string "custom target skeleton path"
default "fs/skeleton"
help
Path to the custom target skeleton

endif

So :

* config statements at the beginning of the line
* one tab before "bool" and "help"
* tab + 2 spaces before each line of the help message

Otherwise, looks good to me, thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#2 lore raw

PATCH 2/2 option to define path to custom rootfs skeleton

Ok. I will redo the patch and resend everything from scratch.

-- Dima

Quoted 83 lines · Thomas Petazzoni

Hello,

Quoted 21 lines · On Thu, 10 Jun 2010 22:58:40 +0300 Dmytro Milinevskyy <[email protected]>…

index 6865eea..2163890 100644

fs/Config.in +0 -0
@@ -23,6 +23,30 @@ config BR2_ROOTFS_DEVICE_TABLE

? ? ? ? ? to the makedevs utility to create all the special device ? ? ? ? ? files in the target filesystem.

fs/Config.in +14 -0
+choice
+ ? ? prompt "Root FS skeleton"
+
+ ? ? config BR2_ROOTFS_SKELETON_DEFAULT
+ ? ? ? ? ? ? bool "default target skeleton"
+ ? ? ? ?help
+ ? ? ? ? ?Use default target skeleton
+
+ ? ? config BR2_ROOTFS_SKELETON_CUSTOM
+ ? ? ? ? ? ? bool "custom target skeleton"
+ ? ? ? ? ? ? help
+ ? ? ? ? ? ? ?Use custom target skeleton.
+
+endchoice

fs/Config.in

Quoted 10 lines
fs/Config.in +10 -0
+
+if BR2_ROOTFS_SKELETON_CUSTOM
+ ? ? config BR2_ROOTFS_SKELETON_CUSTOM_PATH
+ ? ? ? ? ? ? string "custom target skeleton path"
+ ? ? ? ?default "fs/skeleton"
+ ? ? ? ? ? ? help
+ ? ? ? ? ? ? ?Path custom target skeleton.
+endif
+
+

You have indentation issues here. It should be:

choice
? ? ? ?prompt "Root FS skeleton"

config BR2_ROOTFS_SKELETON_DEFAULT
? ? ? ?bool "default target skeleton"
? ? ? ?help
? ? ? ? ?Use default target skeleton

config BR2_ROOTFS_SKELETON_CUSTOM
? ? ? ?bool "custom target skeleton"
? ? ? ?help
? ? ? ? ?Use custom target skeleton

endchoice

if BR2_ROOTFS_SKELETON_CUSTOM

config BR2_ROOTFS_SKELETON_CUSTOM_PATH
? ? ? ?string "custom target skeleton path"
? ? ? ?default "fs/skeleton"
? ? ? ?help
? ? ? ? ?Path to the custom target skeleton

endif

So :

?* config statements at the beginning of the line ?* one tab before "bool" and "help"
?* tab + 2 spaces before each line of the help message

Otherwise, looks good to me, thanks!

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot