Skip to contentSkip to conversation

Display current action in title bar

PATCH New Paul Jones 3 participants 4 messages Jun 14, 2010 – Jun 15, 2010

lore
Share & tools
lore

Paul Jones

author
#0 lore raw

PATCH 1/1 Display current action in title bar

Signed-off-by Paul Jones <[email protected]>
---
 package/Makefile.package.in |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
package/Makefile.package.in +3 -2
index a2720d7..327ab92 100644
@@ -48,8 +48,9 @@ INFLATE.tbz2 = $(BZCAT)
 INFLATE.tgz  = $(ZCAT)
 INFLATE.tar  = cat
 
-# MESSAGE Macro -- display a message in bold type
-MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
+# MESSAGE Macro -- display a message in bold type and in the title bar
+MESSAGE  = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)" \
+		&& echo -en "\033]2; $($(PKG)_NAME) $($(PKG)_VERSION) $(1) \007"
 TERM_BOLD := $(shell tput smso)
 TERM_RESET := $(shell tput rmso)
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 Display current action in title bar

package/Makefile.package.in INFLATE.tbz2 = $(BZCAT) · line 53

Quoted 5 lines · On Mon, 14 Jun 2010 23:47:15 +1000 Paul Jones <[email protected]> wrote:
package/Makefile.package.in +3 -2
-# MESSAGE Macro -- display a message in bold type
-MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
+# MESSAGE Macro -- display a message in bold type and in the title bar
+MESSAGE  = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)" \
+		&& echo -en "\033]2; $($(PKG)_NAME) $($(PKG)_VERSION) $(1) \007"

I've tried this here in my xfterm (XFCE terminal) and it doesn't do anything. Is my terminal emulator too crappy ?

Anyway, I'm not sure I'd like to see Buildroot hijack the title bar of my terminal emulator. Or maybe I'm missing the point of your patch ?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 Display current action in title bar

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> On Mon, 14 Jun 2010 23:47:15 +1000

Quoted 5 lines · Thomas> Paul Jones <[email protected]> wrote:

Review

Quoted 5 lines
(quoted diff) +3 -2
-# MESSAGE Macro -- display a message in bold type
-MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
+# MESSAGE Macro -- display a message in bold type and in the title bar
+MESSAGE  = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)" \
+		&& echo -en "\033]2; $($(PKG)_NAME) $($(PKG)_VERSION) $(1) \007"

Thomas> I've tried this here in my xfterm (XFCE terminal) and it doesn't do Thomas> anything. Is my terminal emulator too crappy ?

Thomas> Anyway, I'm not sure I'd like to see Buildroot hijack the title bar of Thomas> my terminal emulator. Or maybe I'm missing the point of your patch ?

I made a similar patch back in February:

package/Makefile.package.in +1 -1
index fbd7f69..c40f83f 100644
@@ -34,7 +34,7 @@ INFLATE.tgz = $(ZCAT)
 INFLATE.tar = cat
 
 # MESSAGE Macro -- display a message in bold type
-MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
+MESSAGE = echo -e "\033]0;$($(PKG)_NAME) $($(PKG)_VERSION) $(1)\007"
 TERM_BOLD := $(shell tput smso)
 TERM_RESET := $(shell tput rmso)

It's sometimes handy to get an idea of what BR is doing while tons of text scrolls over the screen, but I'm also not convinced we should do it by default.

Signature · 1 line
Bye, Peter Korsgaard
author
#3 lore raw

PATCH 1/1 Display current action in title bar

In reply to Thomas Petazzoni
Quoted 12 lines

-----Original Message-----
From: buildroot-bounces at busybox.net [mailto:buildroot- bounces at busybox.net] On Behalf Of Thomas Petazzoni
Sent: Tuesday, 15 June 2010 7:56 PM
To: buildroot at busybox.net
Subject: Re: [Buildroot] [PATCH] Display current action in title bar

Quoted 2 lines · On Mon, 14 Jun 2010 23:47:15 +1000 Paul Jones <[email protected]> wrote:

-# MESSAGE Macro -- display a message in bold type -MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION)

Quoted 8 lines

$(1)$(TERM_RESET)"

Review

Quoted 2 lines
(quoted diff) +2 -0
+# MESSAGE Macro -- display a message in bold type and in the title
+bar MESSAGE  = echo "$(TERM_BOLD)>>> $($(PKG)_NAME)

$($(PKG)_VERSION) $(1)$(TERM_RESET)" \

Review

Quoted 1 line
(quoted diff) +1 -0
+		&& echo -en "\033]2; $($(PKG)_NAME) $($(PKG)_VERSION)

$(1) \007"

I've tried this here in my xfterm (XFCE terminal) and it doesn't do

anything. Is

Quoted 4 lines

my terminal emulator too crappy ?

Anyway, I'm not sure I'd like to see Buildroot hijack the title bar of my terminal emulator. Or maybe I'm missing the point of your patch ?

It works using the Gnome terminal and Putty. I'll try it on some others. Since the terminal title is usually set by the PS1 variable that means that as soon as builtroot stops running it will return to normal. The Gentoo build system does the same thing and it is quite handy to see what's happening.

Paul.