virtio_net: implements ethtool_ops.get_drvinfo

This patch implements ethtool_ops.get_drvinfo interface of virtio_net driver.

Signed-off-by Taku Izumi <[email protected]>

---
 drivers/net/virtio_net.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)

Index: net-next.35/drivers/net/virtio_net.c
===================================================================

drivers/net/virtio_net.c +13 -0

@@ -701,6 +701,18 @@ static int virtnet_close(struct net_devi
 	return 0;
 }
 
+static void virtnet_get_drvinfo(struct net_device *dev,
+				struct ethtool_drvinfo *drvinfo)
+{
+	struct virtnet_info *vi = netdev_priv(dev);
+	struct virtio_device *vdev = vi->vdev;
+
+	strncpy(drvinfo->driver, KBUILD_MODNAME, 32);
+	strncpy(drvinfo->version, "N/A", 32);
+	strncpy(drvinfo->fw_version, "N/A", 32);
+	strncpy(drvinfo->bus_info, dev_name(&vdev->dev), 32);
+}
+
 static int virtnet_set_tx_csum(struct net_device *dev, u32 data)
 {
 	struct virtnet_info *vi = netdev_priv(dev);

@@ -813,6 +825,7 @@ static void virtnet_vlan_rx_kill_vid(str
 }
 
 static const struct ethtool_ops virtnet_ethtool_ops = {
+	.get_drvinfo = virtnet_get_drvinfo,
 	.set_tx_csum = virtnet_set_tx_csum,
 	.set_sg = ethtool_op_set_sg,
 	.set_tso = ethtool_op_set_tso,

Quoted 3 lines · Taku Izumi

This patch implements ethtool_ops.get_drvinfo interface of virtio_net driver.

Signed-off-by Taku Izumi<[email protected]>

Hi Taku!

Does this have any useful effect?

Hi Rusty,

Quoted 8 lines · Rusty Russell

Quoted 3 lines · Taku Izumi

This patch implements ethtool_ops.get_drvinfo interface of virtio_net driver.

Signed-off-by Taku Izumi<[email protected]>

Hi Taku!

Does this have any useful effect?

I often use "ethtool -i" command to check what driver controls the ehternet device. But because current virtio_net driver doesn't support "ethtool -i", it becomes the following:

	# ethtool -i eth3
	Cannot get driver information: Operation not supported

My patch simply adds the "ethtool -i" support. The following is the result when using the virtio_net driver with my patch applied to.

	# ethtool -i eth3
	driver: virtio_net
	version: N/A
	firmware-version: N/A
	bus-info: virtio0

Personally, "-i" is one of the most frequently-used option, and most network drivers support "ethtool -i", so I think virtio_net also should do.