IPMI: Set schedule_timeout_wait value back to one
PATCH 1/1 IPMI: Set schedule_timeout_wait value back to one
From: Martin Wilck <[email protected]>
Some systems were seeing CPU usage go up dramatically with the recent changes to try to reduce timer usage in the IPMI driver. This was traced down to schedule_timeout_interruptible(1) being changed to schedule_timeout_interruptbile(0). Revert that change.
---
drivers/char/ipmi/ipmi_si_intf.c +1 -1
@@ -1018,7 +1018,7 @@ static int ipmi_thread(void *data)else if (smi_result ==SI_SM_IDLE )schedule_timeout_interruptible (100 );else -schedule_timeout_interruptible (0 ); +schedule_timeout_interruptible (1 ); }return 0 ; }
Quoted 17 lines · On Wed, 16 Jun 2010 08:51:44 -0500 Corey Minyard <[email protected]> wrote:
From: Martin Wilck <[email protected]>
Some systems were seeing CPU usage go up dramatically with the recent changes to try to reduce timer usage in the IPMI driver. This was traced down to
schedule_timeout_interruptible(1)being changed toschedule_timeout_interruptbile(0). Revert that change.Reported-by Thomas Jarosch <[email protected]>Signed-off-by Corey Minyard <[email protected]>Tested-by Thomas Jarosch <[email protected]>---
Index:
linux-2.6/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
drivers/char/ipmi/ipmi_si_intf.c static int ipmi_thread(void *data) · line 1024
Quoted 8 lines
drivers/char/ipmi/ipmi_si_intf.c +1
-1@@ -1018,7 +1018,7 @@ static int ipmi_thread(void *data)else if (smi_result ==SI_SM_IDLE )schedule_timeout_interruptible (100 );else -schedule_timeout_interruptible (0 ); +schedule_timeout_interruptible (1 ); }return 0 ; }
This fixes a regression introduced by ae74e823cb7d ("ipmi: add parameter to limit CPU usage in kipmid"), yes? I noted that in the changelog.
I also noted that it addresses
https://bugzilla.kernel.org/show_bug.cgi?id=16147 and I added the vital(!) cc:[email protected], as we busted 2.6.34.
This is a pretty important -stable fix I think - several people have hit it and the effects are ugly.