Skip to contentSkip to conversation

mpt fusion: Cleanup some duplicate calls in mptbase.c

PATCH In review Bandan Das 2 participants 2 messages Jun 16, 2010 – Jun 17, 2010

Subsystems (2)
SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)
lore
Share & tools
lore

Bandan Das

author
#0 lore raw

PATCH 1/1 mpt fusion: Cleanup some duplicate calls in mptbase.c

In mpt_detach, call to pci_set_drvdata is redundant because it has already been called in mpt_adapter_disable. In mpt_attach, ioc->pcidev is set to pdev two times.

Signed-off-by Bandan Das <[email protected]>
---
 drivers/message/fusion/mptbase.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/message/fusion/mptbase.c +0 -2
index a6a5701..2ec2fa7 100644
@@ -1770,7 +1770,6 @@ mpt_attach(struct pci_dev *pdev, const struct pci_device_id *id)
 	ioc->req_sz = MPT_DEFAULT_FRAME_SIZE;		/* avoid div by zero! */
 	ioc->reply_sz = MPT_REPLY_FRAME_SIZE;
 
-	ioc->pcidev = pdev;
 
 	spin_lock_init(&ioc->taskmgmt_lock);
 	mutex_init(&ioc->internal_cmds.mutex);

@@ -2051,7 +2050,6 @@ mpt_detach(struct pci_dev *pdev)
 
 	mpt_adapter_dispose(ioc);
 
-	pci_set_drvdata(pdev, NULL);
 }
 
 /**************************************************************************
Signature · 1 line
1.6.6.1
#1 lore raw

Barand, I reviewed your below patch and it is valid.

James, Can you please consider this patch as ACKed and consider it for next merge window.

Thanks, Kashyap

Quoted 43 lines

-----Original Message-----
From: Bandan Das [mailto:[email protected]]
Sent: Wednesday, June 16, 2010 11:10 PM
To: James Bottomley
Cc: Desai, Kashyap; [email protected]
Subject: [PATCH] mpt fusion: Cleanup some duplicate calls in mptbase.c

In mpt_detach, call to pci_set_drvdata is redundant because it has already been called in mpt_adapter_disable. In mpt_attach, ioc->pcidev is set to pdev two times.

Signed-off-by Bandan Das <[email protected]>
---
 drivers/message/fusion/mptbase.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/message/fusion/mptbase.c +0 -0
index a6a5701..2ec2fa7 100644
@@ -1770,7 +1770,6 @@ mpt_attach(struct pci_dev *pdev, const struct
 pci_device_id *id)
 	ioc->req_sz = MPT_DEFAULT_FRAME_SIZE;		/* avoid div by

zero! */

drivers/message/fusion/mptbase.c +0 -2
 	ioc->reply_sz = MPT_REPLY_FRAME_SIZE;
 
-	ioc->pcidev = pdev;
 
 	spin_lock_init(&ioc->taskmgmt_lock);
 	mutex_init(&ioc->internal_cmds.mutex);

@@ -2051,7 +2050,6 @@ mpt_detach(struct pci_dev *pdev)
 
 	mpt_adapter_dispose(ioc);
 
-	pci_set_drvdata(pdev, NULL);
 }

/**********************************************************************
****
--
1.6.6.1