Skip to contentSkip to conversation

x86: OLPC: use pr_debug() for EC commands

PATCH In review Andres Salomon 1 participant 2 messages Jun 17, 2010 – Jul 31, 2010 x86

lore
Share & tools
lore

Andres Salomon

author
#0 lore raw

PATCH 1/1 x86: OLPC: use pr_debug() for EC commands

Unconditionally printing EC debug messages was helpful when we were actually debugging the EC, but during normal operation it can get pretty annoying. Using pr_debug allows us finer-grained control.

(Richard, please yell if this shouldn't be done.)

Signed-off-by Andres Salomon <[email protected]>
---
 arch/x86/kernel/olpc.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
arch/x86/kernel/olpc.c +3 -5
index 1566052..f5ff390 100644
@@ -142,7 +142,7 @@ restart:
 	 * The OBF flag will sometimes misbehave due to what we believe
 	 * is a hardware quirk..
 	 */
-	printk(KERN_DEBUG "olpc-ec:  running cmd 0x%x\n", cmd);
+	pr_devel("olpc-ec:  running cmd 0x%x\n", cmd);
 	outb(cmd, 0x6c);
 
 	if (wait_on_ibf(0x6c, 0)) {

@@ -159,8 +159,7 @@ restart:
 						" EC accept data!\n");
 				goto err;
 			}
-			printk(KERN_DEBUG "olpc-ec:  sending cmd arg 0x%x\n",
-					inbuf[i]);
+			pr_devel("olpc-ec:  sending cmd arg 0x%x\n", inbuf[i]);
 			outb(inbuf[i], 0x68);
 		}
 	}

@@ -173,8 +172,7 @@ restart:
 				goto restart;
 			}
 			outbuf[i] = inb(0x68);
-			printk(KERN_DEBUG "olpc-ec:  received 0x%x\n",
-					outbuf[i]);
+			pr_devel("olpc-ec:  received 0x%x\n", outbuf[i]);
 		}
 	}
Signature · 1 line
1.5.6.5
author
#1 lore raw

[tip:x86/olpc] x86, olpc: Use pr_debug() for EC commands

Commit-ID:  25971865d48a8d0ece5307a59dbd3f06d05a7567
Gitweb:     http://git.kernel.org/tip/25971865d48a8d0ece5307a59dbd3f06d05a7567
Author:     Andres Salomon <[email protected]>
AuthorDate: Wed, 16 Jun 2010 23:19:28 -0400
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Fri, 30 Jul 2010 18:01:52 -0700

x86, olpc: Use pr_debug() for EC commands

Unconditionally printing EC debug messages was helpful when we were actually debugging the EC, but during normal operation it can get pretty annoying. Using pr_debug allows us finer-grained control.

Signed-off-by Andres Salomon <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by H. Peter Anvin <[email protected]>
---
 arch/x86/kernel/olpc.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
arch/x86/kernel/olpc.c +3 -5
index 1566052..f5ff3903 100644
@@ -142,7 +142,7 @@ restart:
 	 * The OBF flag will sometimes misbehave due to what we believe
 	 * is a hardware quirk..
 	 */
-	printk(KERN_DEBUG "olpc-ec:  running cmd 0x%x\n", cmd);
+	pr_devel("olpc-ec:  running cmd 0x%x\n", cmd);
 	outb(cmd, 0x6c);
 
 	if (wait_on_ibf(0x6c, 0)) {

@@ -159,8 +159,7 @@ restart:
 						" EC accept data!\n");
 				goto err;
 			}
-			printk(KERN_DEBUG "olpc-ec:  sending cmd arg 0x%x\n",
-					inbuf[i]);
+			pr_devel("olpc-ec:  sending cmd arg 0x%x\n", inbuf[i]);
 			outb(inbuf[i], 0x68);
 		}
 	}

@@ -173,8 +172,7 @@ restart:
 				goto restart;
 			}
 			outbuf[i] = inb(0x68);
-			printk(KERN_DEBUG "olpc-ec:  received 0x%x\n",
-					outbuf[i]);
+			pr_devel("olpc-ec:  received 0x%x\n", outbuf[i]);
 		}
 	}