Skip to contentSkip to conversation

vmware_vga: fix reset value for command register

PATCH New Michael S. Tsirkin 1 participant 1 message Jun 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vmware_vga: fix reset value for command register

Make init value for this register match the spec. BAR address is 0 at init, so enabling it only works by chance.

---

This patch is untested. Could someone who has vmware guests please look at it?
Thanks!

 hw/vmware_vga.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
hw/vmware_vga.c +0 -3
index bf2a699..41c959b 100644
@@ -1240,9 +1240,6 @@ static int pci_vmsvga_initfn(PCIDevice *dev)
 
     pci_config_set_vendor_id(s->card.config, PCI_VENDOR_ID_VMWARE);
     pci_config_set_device_id(s->card.config, SVGA_PCI_DEVICE_ID);
-    s->card.config[PCI_COMMAND]	= PCI_COMMAND_IO |
-                                  PCI_COMMAND_MEMORY |
-                                  PCI_COMMAND_MASTER; /* I/O + Memory */
     pci_config_set_class(s->card.config, PCI_CLASS_DISPLAY_VGA);
     s->card.config[PCI_CACHE_LINE_SIZE]	= 0x08;		/* Cache line size */
     s->card.config[PCI_LATENCY_TIMER] = 0x40;		/* Latency timer */
Signature · 1 line
1.7.1.12.g42b7f