get rid of "cut here" from bug output

PATCH In review Dan Carpenter 3 participants 4 messages Jun 17, 2010 – Jun 18, 2010

Share & tools

Dan Carpenter

author

2010-06-17 12:22 UTC #0 lore raw

PATCH 1/1 get rid of "cut here" from bug output

It's annoying to have chunks of dmesg output instead just the whole output. A lot of times the very interesting information is before the bug happens.

Signed-off-by Dan Carpenter <[email protected]>

kernel/panic.c +1 -1

index 3b16cd9..2db532a 100644
@@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
 {
 	const char *board;
 
-	printk(KERN_WARNING "------------[ cut here ]------------\n");
+	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
 	printk(KERN_WARNING "WARNING: at %s:%d %pS()\n", file, line, caller);
 	board = dmi_get_system_info(DMI_PRODUCT_NAME);
 	if (board)

Borislav Petkov

2010-06-17 12:36 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Thu, Jun 17, 2010 at 02:21:56PM +0200

Quoted 11 lines

It's annoying to have chunks of dmesg output instead just the whole output. A lot of times the very interesting information is before the bug happens.
Signed-off-by Dan Carpenter <[email protected]>
kernel/panic.c +0 -0
index 3b16cd9..2db532a 100644

kernel/panic.c static void warn_slowpath_common(const char *file, int line, void *caller, · line 376

Quoted 5 lines

kernel/panic.c +1 -1

@@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
 {
 	const char *board;
 
-	printk(KERN_WARNING "------------[ cut here ]------------\n");
+	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");

Good idea, we end up requesting the whole dmesg most of the time anyway. However not all bugs are reported through bugzilla, and, frankly bugzilla is kinda sucky when it comes down to communicating with the bug reporter. How about the more generic "send whole dmesg when reporting" instead?

Signature · 5 lines

Regards/Gruss,
Boris.

Operating Systems Research Center
Advanced Micro Devices, Inc.

Andrew Morton

2010-06-18 06:20 UTC #2 lore raw

Quoted 17 lines · On Thu, 17 Jun 2010 14:36:37 +0200 Borislav Petkov <[email protected]> wrote:

From: Dan Carpenter <[email protected]>
Date: Thu, Jun 17, 2010 at 02:21:56PM +0200
Quoted 14 lines
It's annoying to have chunks of dmesg output instead just the whole output. A lot of times the very interesting information is before the bug happens.
Signed-off-by Dan Carpenter <[email protected]>
kernel/panic.c +0 -0
index 3b16cd9..2db532a 100644
@@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
 {
 	const char *board;
 

Quoted 8 lines

kernel/panic.c static void warn_slowpath_common(const char *file, int line, void *caller, · line 376
Quoted 2 lines
kernel/panic.c +1 -1
-	printk(KERN_WARNING "------------[ cut here ]------------\n");
+	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
Good idea, we end up requesting the whole dmesg most of the time anyway. However not all bugs are reported through bugzilla, and, frankly bugzilla is kinda sucky when it comes down to communicating with the bug reporter. How about the more generic "send whole dmesg when reporting" instead?

And the pestiferous thing wordwraps the dmesg output to death, making it amazingly hard to read. s/paste/attach/ maybe.

Borislav Petkov

2010-06-18 09:59 UTC #3 lore raw

From: Andrew Morton <[email protected]>
Date: Fri, Jun 18, 2010 at 02:19:02AM -0400

Quoted 28 lines · On Thu, 17 Jun 2010 14:36:37 +0200 Borislav Petkov <[email protected]> wrote:

Quoted 18 lines
From: Dan Carpenter <[email protected]>
Date: Thu, Jun 17, 2010 at 02:21:56PM +0200
Quoted 14 lines
It's annoying to have chunks of dmesg output instead just the whole output. A lot of times the very interesting information is before the bug happens.
Signed-off-by Dan Carpenter <[email protected]>
kernel/panic.c +0 -0
index 3b16cd9..2db532a 100644
@@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
 {
 	const char *board;
 
Quoted 8 lines
kernel/panic.c static void warn_slowpath_common(const char *file, int line, void *caller, · line 376
Quoted 2 lines
kernel/panic.c +1 -1
-	printk(KERN_WARNING "------------[ cut here ]------------\n");
+	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
Good idea, we end up requesting the whole dmesg most of the time anyway. However not all bugs are reported through bugzilla, and, frankly bugzilla is kinda sucky when it comes down to communicating with the bug reporter. How about the more generic "send whole dmesg when reporting" instead?

Quoted 2 lines

And the pestiferous thing wordwraps the dmesg output to death, making it amazingly hard to read. s/paste/attach/ maybe.

Right, good point.

Signature · 8 lines

Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632