Skip to contentSkip to conversation

mfd: enable onkey on max8925

PATCH New Haojian Zhuang 2 participants 2 messages May 19, 2010 – Jun 18, 2010

lore
Share & tools
lore
#1 lore raw

PATCH 2/5 mfd: enable onkey on max8925

Hi Haojian,

Review int __devinit max8925_device_init(struct · line 624

Quoted 12 lines · Haojian Zhuang
(quoted diff) +7 -0
@@ -596,6 +614,15 @@ int __devinit max8925_device_init(struct
 max8925_chip *chip,
 		dev_err(chip->dev, "Failed to add rtc subdev\n");
 		goto out;
 	}
+
+	ret = mfd_add_devices(chip->dev, 0, &onkey_devs[0],
+			      ARRAY_SIZE(onkey_devs),
+			      &onkey_resources[0], 0);
+	if (ret < 0) {
+		dev_err(chip->dev, "Failed to add onkey subdev\n");
+		goto out;

I think you want goto out_dev here.
I fixed it up for you and applied this patch to my for-next tree.

Cheers,
Samuel.

Quoted 7 lines
(quoted diff) +2 -0
+	}
+
 	if (pdata && pdata->regulator[0]) {
 		ret = mfd_add_devices(chip->dev, 0, &regulator_devs[0],

ARRAY_SIZE(regulator_devs),

Signature · 1 line
1.5.6.5
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/