block: fix some more cmd_type cleanup fallout
Subsystems (2)
PATCH 1/1 block: fix some more cmd_type cleanup fallout
Signed-off-by Christoph Hellwig <[email protected]>
drivers/block/ub.c +1 -1
@@ -648,7 +648,7 @@ static int ub_request_fn_1(struct ub_lunreturn 0 ; } -if (lun->changed && rq->cmd_type !=REQ_TYPE_BLOCK_PC ) +if (lun->changed && rq->cmd_type !=REQ_TYPE_BLOCK_PC ) {blk_start_request (rq);ub_end_rq (rq,SAM_STAT_CHECK_CONDITION );return 0 ;
drivers/ide/ide-atapi.c +3 -3
@@ -307,7 +307,7 @@ EXPORT_SYMBOL_GPL(ide_cd_expiry);int ide_cd_get_xferlen (struct request *rq) { - switch (rq->cmd_type) +switch (rq->cmd_type) {case REQ_TYPE_FS :return 32768 ;case REQ_TYPE_SENSE :
@@ -477,12 +477,12 @@ static ide_startstop_t ide_pc_intr(ide_dif (uptodate ==0 ) drive->failed_pc =NULL ; -if (rq->cmd_type ==REQ_TYPE_SPECIAL ) +if (rq->cmd_type ==REQ_TYPE_SPECIAL ) { rq->errors =0 ; error =0 ; }else { -if (req->cmd_type !=REQ_TYPE_FS && uptodate <=0 ) { +if (rq->cmd_type !=REQ_TYPE_FS && uptodate <=0 ) {if (rq->errors ==0 ) rq->errors = -EIO ; }
drivers/ide/ide-cd.c +2 -2
@@ -318,7 +318,7 @@ static int cdrom_decode_status(ide_drivecdrom_saw_media_change (drive);if (rq->cmd_type ==REQ_TYPE_FS && - !(rq->cmd_flags &REQ_QUIET )) { + !(rq->cmd_flags &REQ_QUIET )) printk(KERN_ERR PFX "%s: tray open\n", drive->name); }
@@ -375,7 +375,7 @@ static int cdrom_decode_status(ide_drive do_end_request =1 ;break ;default : -if (req->cmd_type !=REQ_TYPE_FS ) +if (rq->cmd_type !=REQ_TYPE_FS )break ;if (err & ~ATA_ABORTED ) {/* go to the default handler for other errors */
drivers/ide/ide-io.c +1 -1
@@ -353,7 +353,7 @@ static ide_startstop_t start_request (id pm->pm_step == IDE_PM_COMPLETED)ide_complete_pm_rq (drive, rq);return startstop; - }else if (!rq->rq_disk && rq->cmd_type ==REQ_TYPE_SPECIAL ) { + }else if (!rq->rq_disk && rq->cmd_type ==REQ_TYPE_SPECIAL )/* * TODO: Once all ULDs have been modified to * check for specific op codes rather than
Jens Axboe
maintainerQuoted 71 lines · Christoph Hellwig
Signed-off-by Christoph Hellwig <[email protected]>Index:
linux-2.6/drivers/block/ub.c
===================================================================drivers/block/ub.c +1
-1@@ -648,7 +648,7 @@ static int ub_request_fn_1(struct ub_lunreturn 0 ; } -if (lun->changed && rq->cmd_type !=REQ_TYPE_BLOCK_PC ) +if (lun->changed && rq->cmd_type !=REQ_TYPE_BLOCK_PC ) {blk_start_request (rq);ub_end_rq (rq,SAM_STAT_CHECK_CONDITION );return 0 ;Index:
linux-2.6/drivers/ide/ide-atapi.c
===================================================================drivers/ide/ide-atapi.c +3
-3@@ -307,7 +307,7 @@ EXPORT_SYMBOL_GPL(ide_cd_expiry);int ide_cd_get_xferlen (struct request *rq) { - switch (rq->cmd_type) +switch (rq->cmd_type) {case REQ_TYPE_FS :return 32768 ;case REQ_TYPE_SENSE :@@ -477,12 +477,12 @@ static ide_startstop_t ide_pc_intr(ide_dif (uptodate ==0 ) drive->failed_pc =NULL ; -if (rq->cmd_type ==REQ_TYPE_SPECIAL ) +if (rq->cmd_type ==REQ_TYPE_SPECIAL ) { rq->errors =0 ; error =0 ; }else { -if (req->cmd_type !=REQ_TYPE_FS && uptodate <=0 ) { +if (rq->cmd_type !=REQ_TYPE_FS && uptodate <=0 ) {if (rq->errors ==0 ) rq->errors = -EIO ; }Index:
linux-2.6/drivers/ide/ide-cd.c
===================================================================drivers/ide/ide-cd.c +2
-2@@ -318,7 +318,7 @@ static int cdrom_decode_status(ide_drivecdrom_saw_media_change (drive);if (rq->cmd_type ==REQ_TYPE_FS && - !(rq->cmd_flags &REQ_QUIET )) { + !(rq->cmd_flags &REQ_QUIET )) printk(KERN_ERR PFX "%s: tray open\n", drive->name); }@@ -375,7 +375,7 @@ static int cdrom_decode_status(ide_drive do_end_request =1 ;break ;default : -if (req->cmd_type !=REQ_TYPE_FS ) +if (rq->cmd_type !=REQ_TYPE_FS )break ;if (err & ~ATA_ABORTED ) {/* go to the default handler for other errors */ Index:
linux-2.6/drivers/ide/ide-io.c
===================================================================
drivers/ide/ide-io.c static ide_startstop_t start_request (id · line 359
Quoted 8 lines
drivers/ide/ide-io.c +1
-1@@ -353,7 +353,7 @@ static ide_startstop_t start_request (id pm->pm_step == IDE_PM_COMPLETED)ide_complete_pm_rq (drive, rq);return startstop; - }else if (!rq->rq_disk && rq->cmd_type ==REQ_TYPE_SPECIAL ) { + }else if (!rq->rq_disk && rq->cmd_type ==REQ_TYPE_SPECIAL )/* * TODO: Once all ULDs have been modified to * check for specific op codes rather than
Thanks, my build missed those.
Signature · 1 line
Jens Axboe