Skip to contentSkip to conversation

hwmon: (asc7621) Clean up and improve detect

PATCH New Jean Delvare 1 participant 1 message Jun 20, 2010

Subsystems (2)
Hardware monitoring ASC7621 hardware monitor driver
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 hwmon: (asc7621) Clean up and improve detect

* The dev variable is never used.
* Detect functions only need to set info->type, not client->name.
* Include the device address in the log message.

Signed-off-by Jean Delvare <[email protected]>
Cc George Joseph <[email protected]>
Cc Ken Milmore <[email protected]>
---
 drivers/hwmon/asc7621.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/hwmon/asc7621.c +2 -7
@@ -1150,9 +1150,6 @@ static int asc7621_detect(struct i2c_cli
 {
 	struct i2c_adapter *adapter = client->adapter;
 	int company, verstep, chip_index;
-	struct device *dev;
-
-	dev = &client->dev;
 
 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
 		return -ENODEV;

@@ -1169,13 +1166,11 @@ static int asc7621_detect(struct i2c_cli
 
 		if (company = asc7621_chips[chip_index].company_id &&
 		    verstep = asc7621_chips[chip_index].verstep_id) {
-			strlcpy(client->name, asc7621_chips[chip_index].name,
-				I2C_NAME_SIZE);
 			strlcpy(info->type, asc7621_chips[chip_index].name,
 				I2C_NAME_SIZE);
 
-			dev_info(&adapter->dev, "Matched %s\n",
-				 asc7621_chips[chip_index].name);
+			dev_info(&adapter->dev, "Matched %s at 0x%02x\n",
+				 asc7621_chips[chip_index].name, client->addr);
 			return 0;
 		}
 	}
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors