Skip to contentSkip to conversation

i915: return -EFAULT if copy_to_user fails

PATCH In review Dan Carpenter 2 participants 3 messages Jun 23, 2010 – Aug 23, 2010

Subsystems (3)
DRM drivers Intel i915 Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 i915: return -EFAULT if copy_to_user fails

copy_to_user() returns the number of bytes remaining to be copied and I'm pretty sure we want to return a negative error code here.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/i915/i915_gem.c +1 -0
index 9ded3da..22691b4 100644
@@ -3707,6 +3707,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
 		if (ret != 0) {
 			DRM_ERROR("copy %d cliprects failed: %d\n",
 				  args->num_cliprects, ret);
+			ret = -EFAULT;
 			goto pre_mutex_err;
 		}
 	}
author
#1 lore raw
Quoted 3 lines · Dan Carpenter

copy_to_user() returns the number of bytes remaining to be copied and I'm pretty sure we want to return a negative error code here.

This patch wasn't applied either.

regards,
dan carpenter

Quoted 14 lines
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/i915/i915_gem.c +1 -0
index 9ded3da..22691b4 100644
@@ -3707,6 +3707,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
 		if (ret != 0) {
 			DRM_ERROR("copy %d cliprects failed: %d\n",
 				  args->num_cliprects, ret);
+			ret = -EFAULT;
 			goto pre_mutex_err;
 		}
 	}