Skip to contentSkip to conversation

Documentation: fix ubuntu distro name

PATCH Applied Kulikov Vasiliy 4 participants 8 messages Jun 29, 2010 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: fix ubuntu distro name

10.04 is Lucid, not Karmic.

---
 Documentation/coccinelle.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/coccinelle.txt +1 -1
index ba3315d..cd2b028 100644
@@ -14,7 +14,7 @@ of many distributions, e.g. :
 
  - Debian (>=squeeze)
  - Fedora (>=13)
- - Ubuntu (>=10.04 Karmic Koala)
+ - Ubuntu (>=10.04 Lucid Lynx)
  - OpenSUSE
  - Arch Linux
  - NetBSD
Signature · 1 line
1.7.0.4
#1 lore raw

Hi Kulikov,

Indeed. I mixed things.

But Coccinelle was already in Karmic [1]. Can you submit a patch with 9.10 instead of 10.04 ?

I will Ack it.

Thanks.

[1] https://launchpad.net/ubuntu/+source/coccinelle

Quoted 23 lines · On Tuesday 29 June 2010 14:31:16 Kulikov Vasiliy wrote:

10.04 is Lucid, not Karmic.

---
 Documentation/coccinelle.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/coccinelle.txt +1 -1
index ba3315d..cd2b028 100644
@@ -14,7 +14,7 @@ of many distributions, e.g. :
 
  - Debian (>=squeeze)
  - Fedora (>=13)
- - Ubuntu (>=10.04 Karmic Koala)
+ - Ubuntu (>=10.04 Lucid Lynx)
  - OpenSUSE
  - Arch Linux
  - NetBSD
Signature · 4 lines
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/
#2 lore raw
Quoted 4 lines · Nicolas Palix

Hi Kulikov,

Indeed. I mixed things.

Quoted 8 lines

But Coccinelle was already in Karmic [1]. Can you submit a patch with 9.10 instead of 10.04 ?

I will Ack it.

Thanks.

[1] https://launchpad.net/ubuntu/+source/coccinelle

As you see in [1], coccinelle version in Karmic is 0.1.9. I don't know if it is buggy for linux.

In documentation it is 0.2.0:

Quoted 10 lines

Coccinelle (>=0.2.0) is available through the package manager of many distributions, e.g. :

- Debian (>=squeeze)
- Fedora (>=13)
- Ubuntu (>=10.04 Lucid Lynx)
- OpenSUSE
- Arch Linux
- NetBSD
- FreeBSD

So, if 0.1.9 is OK, I can make smth like this:

Quoted 1 line

- Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)

#3 lore raw
Quoted 26 lines · Kulikov Vasiliy
Quoted 10 lines

Indeed. I mixed things.

But Coccinelle was already in Karmic [1]. Can you submit a patch with 9.10 instead of 10.04 ?

I will Ack it.

Thanks.

[1] https://launchpad.net/ubuntu/+source/coccinelle

As you see in [1], coccinelle version in Karmic is 0.1.9. I don't know if it is buggy for linux.

In documentation it is 0.2.0:

Quoted 10 lines

Coccinelle (>=0.2.0) is available through the package manager of many distributions, e.g. :

- Debian (>=squeeze)
- Fedora (>=13)
- Ubuntu (>=10.04 Lucid Lynx)
- OpenSUSE
- Arch Linux
- NetBSD
- FreeBSD

Quoted 2 lines

So, if 0.1.9 is OK, I can make smth like this:

Quoted 1 line

- Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)

Do we really want all this in kernel documentation in the first place?

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#4 lore raw
Quoted 28 lines · On Tuesday 29 June 2010 15:01:14 Jiri Kosina wrote:
Quoted 26 lines · Kulikov Vasiliy
Quoted 10 lines

Indeed. I mixed things.

But Coccinelle was already in Karmic [1]. Can you submit a patch with 9.10 instead of 10.04 ?

I will Ack it.

Thanks.

[1] https://launchpad.net/ubuntu/+source/coccinelle

As you see in [1], coccinelle version in Karmic is 0.1.9. I don't know if it is buggy for linux.

In documentation it is 0.2.0:

Quoted 10 lines

Coccinelle (>=0.2.0) is available through the package manager of many distributions, e.g. :

- Debian (>=squeeze)
- Fedora (>=13)
- Ubuntu (>=10.04 Lucid Lynx)
- OpenSUSE
- Arch Linux
- NetBSD
- FreeBSD

Quoted 5 lines
Quoted 2 lines

So, if 0.1.9 is OK, I can make smth like this:

Quoted 1 line

- Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)

Do we really want all this in kernel documentation in the first place?

It addresses a comment [1] I got during the review process.

[1] http://lkml.org/lkml/2010/5/10/316

Quoted 1 line
Signature · 4 lines
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/
#5 lore raw
In reply to Kulikov Vasiliy
Quoted 29 lines · On Tuesday 29 June 2010 14:59:01 Kulikov Vasiliy wrote:
Quoted 4 lines · Nicolas Palix

Hi Kulikov,

Indeed. I mixed things.

Quoted 8 lines

But Coccinelle was already in Karmic [1]. Can you submit a patch with 9.10 instead of 10.04 ?

I will Ack it.

Thanks.

[1] https://launchpad.net/ubuntu/+source/coccinelle

As you see in [1], coccinelle version in Karmic is 0.1.9. I don't know if it is buggy for linux.

In documentation it is 0.2.0:

Quoted 10 lines

Coccinelle (>=0.2.0) is available through the package manager of many distributions, e.g. :

- Debian (>=squeeze)
- Fedora (>=13)
- Ubuntu (>=10.04 Lucid Lynx)
- OpenSUSE
- Arch Linux
- NetBSD
- FreeBSD

Quoted 3 lines

So, if 0.1.9 is OK, I can make smth like this:

Quoted 1 line

- Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)

I figured out that point later, and sent a Acked-by for your original patch. I think our mails have crossed each other.

Indeed, the version 0.1.9 does not provide the virtual rule feature, which is required for the coccinelle files we have submitted.

Signature · 2 lines
Nicolas Palix
Web: http://www.diku.dk/~npalix/
Acked-by on v1 1/1
#6 lore raw
In reply to Kulikov Vasiliy

The version in Karmic is too old. The right correction is indeed Lucid Lynx.

Quoted 13 lines · On Tuesday 29 June 2010 14:31:16 Kulikov Vasiliy wrote:

10.04 is Lucid, not Karmic.

---
 Documentation/coccinelle.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/coccinelle.txt +0 -0
index ba3315d..cd2b028 100644

Documentation/coccinelle.txt of many distributions, e.g. : · line 20

Quoted 8 lines
Documentation/coccinelle.txt +1 -1
@@ -14,7 +14,7 @@ of many distributions, e.g. :
 
  - Debian (>=squeeze)
  - Fedora (>=13)
- - Ubuntu (>=10.04 Karmic Koala)
+ - Ubuntu (>=10.04 Lucid Lynx)
  - OpenSUSE
  - Arch Linux
  - NetBSD
Signature · 4 lines
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/
Applied
#7 lore raw
Quoted 17 lines · Nicolas Palix

The version in Karmic is too old. The right correction is indeed Lucid Lynx.

Quoted 13 lines · On Tuesday 29 June 2010 14:31:16 Kulikov Vasiliy wrote:

10.04 is Lucid, not Karmic.

---
 Documentation/coccinelle.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/coccinelle.txt +0 -0
index ba3315d..cd2b028 100644
@@ -14,7 +14,7 @@ of many distributions, e.g. :
 
Quoted 10 lines

Documentation/coccinelle.txt of many distributions, e.g. : · line 20

Quoted 8 lines
Documentation/coccinelle.txt +1 -1
  - Debian (>=squeeze)
  - Fedora (>=13)
- - Ubuntu (>=10.04 Karmic Koala)
+ - Ubuntu (>=10.04 Lucid Lynx)
  - OpenSUSE
  - Arch Linux
  - NetBSD

Applied.

Michal