device-assignment: Clear assigned_dev irq type
PATCH 1/1 device-assignment: Clear assigned_dev irq type
Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled, but what we really want is to clear assigned_dev->irq_requested_type.
Signed-off-by Alex Williamson <[email protected]>
Found-by Juan Quintela <[email protected]>
---
hw/device-assignment.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
hw/device-assignment.c +2 -2
@@ -1044,7 +1044,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)if (r && r != -ENXIO )perror ("assigned_dev_update_msi: deassign irq" ); - assigned_irq_data.flags =0 ; + assigned_dev->irq_requested_type =0 ; }if (ctrl_byte &PCI_MSI_FLAGS_ENABLE ) {
@@ -1208,7 +1208,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)if (r && r != -ENXIO )perror ("assigned_dev_update_msix: deassign irq" ); - assigned_irq_data.flags =0 ; + assigned_dev->irq_requested_type =0 ; }if (*ctrl_word &PCI_MSIX_ENABLE ) {
Quoted 5 lines · * Alex Williamson ([email protected]) wrote:
Commit
96abccb5cleared assigned_irq_data.flags when an irq is disabled, but what we really want is to clearassigned_dev->irq_requested_type.Signed-off-by Alex Williamson <[email protected]>Found-by Juan Quintela <[email protected]>
Acked-by Chris Wright <[email protected]>
Quoted 5 lines · Alex Williamson
Commit
96abccb5cleared assigned_irq_data.flags when an irq is disabled, but what we really want is to clearassigned_dev->irq_requested_type.Signed-off-by Alex Williamson <[email protected]>Found-by Juan Quintela <[email protected]>
Acked-by Juan Quintela <[email protected]>
Quoted 27 lines
---
hw/device-assignment.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)hw/device-assignment.c +2
-2@@ -1044,7 +1044,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)if (r && r != -ENXIO )perror ("assigned_dev_update_msi: deassign irq" ); - assigned_irq_data.flags =0 ; + assigned_dev->irq_requested_type =0 ; }if (ctrl_byte &PCI_MSI_FLAGS_ENABLE ) {@@ -1208,7 +1208,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)if (r && r != -ENXIO )perror ("assigned_dev_update_msix: deassign irq" ); - assigned_irq_data.flags =0 ; + assigned_dev->irq_requested_type =0 ; }if (*ctrl_word &PCI_MSIX_ENABLE ) {
Marcelo Tosatti
AppliedQuoted 9 lines · Alex Williamson
Commit
96abccb5cleared assigned_irq_data.flags when an irq is disabled, but what we really want is to clearassigned_dev->irq_requested_type.Signed-off-by Alex Williamson <[email protected]>Found-by Juan Quintela <[email protected]>---
hw/device-assignment.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.