OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
PATCH 1/1 OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
CPU performance event counters on v7 cores will only operate if either the NIDEN or DBGEN signals are driven high.
For the OMAP3 platform, these signals are driven low by default [i.e. when a JTAG debugger is not connected] but DBGEN can be asserted in software by selecting the OMAP3_EMU Kconfig option, which enables the virtual clock for hardware debugging peripherals.
This patch makes CPU_HAS_PMU depend on OMAP3_EMU for OMAP3 platforms.
---
Since I don't have an OMAP3 board to test this on I would appreciate it if somebody with some hardware could (a) confirm that this problem exists and (b) validate that this patch solves the issue. Thanks!
arch/arm/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/Kconfig +2 -1
@@ -955,7 +955,8 @@ config XSCALE_PMU default y config CPU_HAS_PMU - depends on CPU_V6 || CPU_V7 || XSCALE_PMU + depends on (CPU_V6 || CPU_V7 || XSCALE_PMU) && \ + (!ARCH_OMAP3 || OMAP3_EMU) default y bool
Signature · 1 line
1.6.3.3
PATCH 1/1 OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
Hi Will,
Sorry for the late reply. Here below are the test results. Re-sending in plain text only, sorry for the inconvenience.
Quoted 37 lines · Will Deacon
CPU performance event counters on v7 cores will only operate if either the NIDEN or DBGEN signals are driven high.
For the OMAP3 platform, these signals are driven low by default [i.e. when a JTAG debugger is not connected] but DBGEN can be asserted in software by selecting the
OMAP3_EMUKconfigoption, which enables the virtual clock for hardware debugging peripherals.This patch makes
CPU_HAS_PMUdepend onOMAP3_EMUfor OMAP3 platforms.Cc Tony Lindgren <[email protected]>Cc Jean Pihet <[email protected]>Signed-off-by Will Deacon <[email protected]>---
Since I don't have an OMAP3 board to test this on I would appreciate it if somebody with some hardware could (a) confirm that this problem exists and (b) validate that this patch solves the issue. Thanks!
arch/arm/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/arm/Kconfig +2
-2@@ -955,7 +955,8 @@ config XSCALE_PMU default y config CPU_HAS_PMU - depends on CPU_V6 || CPU_V7 || XSCALE_PMU + depends on (CPU_V6 || CPU_V7 || XSCALE_PMU) && \ + (!ARCH_OMAP3 || OMAP3_EMU) default y bool --
Quoted 3 lines
1.6.3.3
The patch nicely fixes the issue. Tested with Oprofile on OMAP3530 EVM. RETention and OFF power modes succesfully tested.
Regards,
Jean
PATCH 1/1 OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
Jean,
Quoted 22 lines
Quoted 15 lines
arch/arm/Kconfig +2
-2@@ -955,7 +955,8 @@ config XSCALE_PMU default y config CPU_HAS_PMU - depends on CPU_V6 || CPU_V7 || XSCALE_PMU + depends on (CPU_V6 || CPU_V7 || XSCALE_PMU) && \ + (!ARCH_OMAP3 || OMAP3_EMU) default y bool --Quoted 3 lines
1.6.3.3
The patch nicely fixes the issue. Tested with Oprofile on OMAP3530 EVM. RETention and OFF power modes succesfully tested.
Quoted 1 line
Acked-by Jean Pihet <[email protected]>
Brilliant - thanks for testing this.
Tony: would you mind picking this patch up please or would you prefer that I posted it to Russell's patch system?
Thanks,
Will
PATCH 1/1 OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
In reply to Jean PihetHello,
Quoted 2 lines · * I wrote:
Tony: would you mind picking this patch up please or would you prefer that I posted it to Russell's patch system?
Since this only modifies arch/arm/KConfig and Jean has acked it, I've submitted it to Russell's patch system as #6195/1.
Will
PATCH 1/1 OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
Quoted 9 lines · Will Deacon
Hello,
Quoted 2 lines · * I wrote:
Tony: would you mind picking this patch up please or would you prefer that I posted it to Russell's patch system?
Since this only modifies
arch/arm/KConfigand Jean has acked it, I've submitted it to Russell's patch system as #6195/1.
Yeah good, thanks.
Tony