drm: add vblank event trace point
Subsystems (3)
PATCH 1/3 drm: add vblank event trace point
Emit a trace point for vblank events. This can be helpful for mapping drawing activity against the vblank frequency and period.
Signed-off-by Jesse Barnes <[email protected]>
--- drivers/gpu/drm/Makefile | 5 +++- drivers/gpu/drm/drm_irq.c | 3 ++ drivers/gpu/drm/drm_trace.h | 37 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_trace_points.c | 4 +++ 4 files changed, 48 insertions(+), 1 deletions(-) create mode 100644 drivers/gpu/drm/drm_trace.h create mode 100644 drivers/gpu/drm/drm_trace_points.c
drivers/gpu/drm/Makefile +4 -1
@@ -11,7 +11,8 @@ drm-y := drm_auth.o drm_buffer.o drm_bufs.o drm_cache.o \ drm_agpsupport.o drm_scatter.o ati_pcigart.o drm_pci.o \ drm_sysfs.o drm_hashtab.o drm_sman.o drm_mm.o \ drm_crtc.o drm_modes.o drm_edid.o \ - drm_info.o drm_debugfs.o drm_encoder_slave.o + drm_info.o drm_debugfs.o drm_encoder_slave.o \ + drm_trace_points.o drm-$(CONFIG_COMPAT) += drm_ioc32.o
@@ -19,6 +20,8 @@ drm_kms_helper-y := drm_fb_helper.o drm_crtc_helper.o drm_dp_i2c_helper.o obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o +CFLAGS_drm_trace_points.o := -I$(src) + obj-$(CONFIG_DRM) += drm.o obj-$(CONFIG_DRM_TTM) += ttm/ obj-$(CONFIG_DRM_TDFX) += tdfx/
drivers/gpu/drm/drm_irq.c +3 -0
@@ -34,6 +34,7 @@*/ #include "drmP.h" +#include "drm_trace.h" #include <linux/interrupt.h> /* For task queue support */ #include <linux/slab.h>
@@ -754,6 +755,8 @@ void drm_handle_vblank_events(struct drm_device *dev, int crtc) }spin_unlock_irqrestore (&dev->event_lock, flags); + +trace_drm_vblank_event (crtc, seq); }/**
drivers/gpu/drm/drm_trace.h new file +37 -0
@@ -0,0 +1,37 @@ +#if !defined(_DRM_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ ) +#define _DRM_TRACE_H_ + +#include <linux/stringify.h> +#include <linux/types.h> +#include <linux/tracepoint.h> + +#undef TRACE_SYSTEM +#define TRACE_SYSTEM drm +#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) +#define TRACE_INCLUDE_FILE drm_trace + +TRACE_EVENT (drm_vblank_event, + + TP_PROTO(int crtc, unsigned int seq), + +TP_ARGS (crtc, seq), + +TP_STRUCT__entry ( + __field(int, crtc) + __field(unsigned int, seq) + ), + +TP_fast_assign ( + __entry->crtc = crtc; + __entry->seq = seq; + ), + +TP_printk ("crtc=%d, seq=%d" , __entry->crtc, __entry->seq) +); + +#endif /* _DRM_TRACE_H_ */ + +/* This part must be outside protection */ +#undef TRACE_INCLUDE_PATH +#define TRACE_INCLUDE_PATH . +#include <trace/define_trace.h>
drivers/gpu/drm/drm_trace_points.c new file +4 -0
@@ -0,0 +1,4 @@ +#include "drmP.h" + +#define CREATE_TRACE_POINTS +#include "drm_trace.h"
Signature · 1 line
1.6.1.3
PATCH 2/3 drm: add per-event vblank event trace points
Allows us to track each process that requests and completes events.
Signed-off-by Jesse Barnes <[email protected]>
--- drivers/gpu/drm/drm_irq.c | 8 ++++++ drivers/gpu/drm/drm_trace.h | 57 ++++++++++++++++++++++++++++++++---------- include/drm/drmP.h | 2 + 3 files changed, 53 insertions(+), 14 deletions(-)
drivers/gpu/drm/drm_irq.c +8 -0
@@ -588,6 +588,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe,return -ENOMEM ; e->pipe = pipe; + e->base.pid = current->pid; e->event.base.type =DRM_EVENT_VBLANK ; e->event.base.length =sizeof e->event; e->event.user_data = vblwait->request.signal;
@@ -615,6 +616,9 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe,DRM_DEBUG ("event on vblank count %d, current %d, crtc %d\n" , vblwait->request.sequence, seq, pipe); +trace_drm_vblank_event_queued (current->pid, pipe, + vblwait->request.sequence); + e->event.sequence = vblwait->request.sequence;if ((seq - vblwait->request.sequence) <= (1 <<23 )) { e->event.tv_sec = now.tv_sec;
@@ -622,6 +626,8 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe,drm_vblank_put (dev, e->pipe);list_add_tail (&e->base.link, &e->base.file_priv->event_list);wake_up_interruptible (&e->base.file_priv->event_wait); +trace_drm_vblank_event_delivered (current->pid, pipe, + vblwait->request.sequence); }else {list_add_tail (&e->base.link, &dev->vblank_event_list); }
@@ -752,6 +758,8 @@ void drm_handle_vblank_events(struct drm_device *dev, int crtc)drm_vblank_put (dev, e->pipe);list_move_tail (&e->base.link, &e->base.file_priv->event_list);wake_up_interruptible (&e->base.file_priv->event_wait); +trace_drm_vblank_event_delivered (e->base.pid, e->pipe, + e->event.sequence); }spin_unlock_irqrestore (&dev->event_lock, flags);
drivers/gpu/drm/drm_trace.h +43 -14
65 lines not on this page · raw message
include/drm/drmP.h +2 -0
@@ -403,6 +403,8 @@ struct drm_pending_event {struct drm_event *event;struct list_head link;struct drm_file *file_priv; +pid_t pid;/* pid of requester, no guarantee it's valid by the time +we deliver the event, for tracing only */ void (*destroy)(struct drm_pending_event *event); };
Signature · 1 line
1.6.1.3
PATCH 3/3 drm/i915: add tracepoints for flip requests & completions
In reply to Jesse BarnesSigned-off-by Jesse Barnes <[email protected]>
--- drivers/gpu/drm/i915/i915_trace.h | 36 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_display.c | 5 ++++ 2 files changed, 41 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +36 -0
@@ -262,6 +262,42 @@ DEFINE_EVENT(i915_ring, i915_ring_wait_end,TP_ARGS (dev) ); +TRACE_EVENT (i915_flip_request, + TP_PROTO(int plane, struct drm_gem_object *obj), + +TP_ARGS (plane, obj), + +TP_STRUCT__entry ( + __field(int, plane) + __field(struct drm_gem_object *, obj) + ), + +TP_fast_assign ( + __entry->plane = plane; + __entry->obj = obj; + ), + +TP_printk ("plane=%d, obj=%p" , __entry->plane, __entry->obj) +); + +TRACE_EVENT (i915_flip_complete, + TP_PROTO(int plane, struct drm_gem_object *obj), + +TP_ARGS (plane, obj), + +TP_STRUCT__entry ( + __field(int, plane) + __field(struct drm_gem_object *, obj) + ), + +TP_fast_assign ( + __entry->plane = plane; + __entry->obj = obj; + ), + +TP_printk ("plane=%d, obj=%p" , __entry->plane, __entry->obj) +); +#endif /* _I915_TRACE_H_ */ /* This part must be outside protection */
drivers/gpu/drm/i915/intel_display.c +5 -0
@@ -33,6 +33,7 @@#include "intel_drv.h" #include "i915_drm.h" #include "i915_drv.h" +#include "i915_trace.h" #include "drm_dp_helper.h" #include "drm_crtc_helper.h"
@@ -4648,6 +4649,8 @@ void intel_finish_page_flip(struct drm_device *dev, int pipe) atomic_dec_and_test(&obj_priv->pending_flip))DRM_WAKEUP (&dev_priv->pending_flip_queue);schedule_work (&work->work); + +trace_i915_flip_complete (intel_crtc->plane, work->pending_flip_obj); }void intel_prepare_page_flip (struct drm_device *dev,int plane)
@@ -4749,6 +4752,8 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,mutex_unlock (&dev->struct_mutex); +trace_i915_flip_request (intel_crtc->plane, obj); +return 0 ; }
Signature · 1 line
1.6.1.3
Dave Airlie
maintainerQuoted 3 lines · Jesse Barnes
Emit a trace point for vblank events. This can be helpful for mapping drawing activity against the vblank frequency and period.
Pushed these 3 out to drm-core-next.
Dave.