FB: Add some members for CPU Interface.
PATCH 1/3 FB: Add some members for CPU Interface.
Hi, Andrew,
cpu timing variables could be used generically.
now fb.h and modedb.c file have been considered only for video mode.
but the way of transfering screen data includes also command mode(cpu mode or i80 mode) so I thought it should be added things for it to fb_varscreeninfo struct.
Could you please tell me why cpu timing variables are specific to s3c-fb? ------- Original Message -------
Sender : Andrew Morton<[email protected]>
Date : 2010-07-02 07:26 (GMT+09:00)
Title : Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Quoted 7 lines · On Tue, 29 Jun 2010 19:28:14 +0900 InKi Dae <[email protected]> wrote:
CPU interface needs cs, wr setup, wr act and hold delay. I added some members for them to common framework.
Signed-off-by InKi Dae <inki.dae at samsung.com <mailto:[email protected]>>Signed-off-by Kyungmin Park <[email protected]<mailto:[email protected]>>
These email addresses are mangled.
include/linux/fb.h
Quoted 5 lines
drivers/video/modedb.c +0
-0include/linux/fb.h +0
-0
The patch seems pretty specific to s3c-fb. Is it possible and sensible to somhow avoid adding code to generic files? Can we push more (or all) of these changes into s3c-fb.c or into the arch/arm support code?
PATCH 1/3 FB: Add some members for CPU Interface.
Quoted 8 lines · On Fri, 02 Jul 2010 01:21:12 +0000 (GMT) In-Ki Dae <[email protected]> wrote:
Hi, Andrew,
cpu timing variables could be used generically.
nowfb.handmodedb.cfile have been considered only for video mode.
but the way of transfering screen data includes also command mode(cpu mode or i80 mode) so I thought it should be added things for it tofb_varscreeninfostruct.Could you please tell me why cpu timing variables are specific to s3c-fb?
I dunno - I was just looking at the code.
I don't even know what "cpu timing variables" _are_, in the context of video drivers. Look at this:
Quoted 2 lines
Quoted 2 lines
CPU interface needs cs, wr setup, wr act and hold delay. I added some members for them to common framework.
It's gobbledigook! Please, write patch descriptions which help poor dumb people who don't have detailed knowledge of the particular hardware understand your patch?