Skip to contentSkip to conversation

cxgb4: Use kfree_skb for skb pointers

PATCH RESEND In review Denis Kirjanov 4 participants 5 messages Jul 1, 2010 – Jul 3, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Denis Kirjanov

author
#0 lore raw

PATCH RESEND 1/1 cxgb4: Use kfree_skb for skb pointers

Use kfree_skb for skb pointers

Acked-by Dimitris Michailidis <[email protected]>
Signed-off-by Denis Kirjanov <[email protected]>

---
drivers/net/cxgb4/l2t.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/cxgb4/l2t.c +1 -1
index 5b990d2..e8f0f55 100644
@@ -314,7 +314,7 @@ static void t4_l2e_free(struct l2t_entry *e)
 			struct sk_buff *skb = e->arpq_head;
 
 			e->arpq_head = skb->next;
-			kfree(skb);
+			kfree_skb(skb);
 		}
 		e->arpq_tail = NULL;
 	}
#2 lore raw
Quoted 6 lines

From: Denis Kirjanov <[email protected]>
Date: Thu, 1 Jul 2010 09:45:52 +0000

Quoted 2 lines

Use kfree_skb for skb pointers

Quoted 8 lines
Quoted 2 lines
Acked-by Dimitris Michailidis <[email protected]>
Signed-off-by Denis Kirjanov <[email protected]>

The code is completely different in this part of the driver now, this patch does not apply.

In fact there is no reference to the string "kfree" at all in the l2t.c file of the cxgb4 driver :)

This patch is for net-next and it should apply there, I see the wrong kfree (there's only one kfree). Denis didn't mention net-next, maybe you tried to apply it to net-2.6?

maintainer
#3 lore raw

From: "Dimitrios Michailidis" <[email protected]>
Date: Fri, 2 Jul 2010 22:51:17 -0700

Quoted 12 lines
Quoted 12 lines

From: Denis Kirjanov <[email protected]>
Date: Thu, 1 Jul 2010 09:45:52 +0000

Quoted 4 lines

Use kfree_skb for skb pointers

Acked-by Dimitris Michailidis <[email protected]>
Signed-off-by Denis Kirjanov <[email protected]>

The code is completely different in this part of the driver now, this patch does not apply.

Quoted 6 lines
Quoted 2 lines

In fact there is no reference to the string "kfree" at all in the l2t.c file of the cxgb4 driver :)

This patch is for net-next and it should apply there, I see the wrong kfree (there's only one kfree). Denis didn't mention net-next, maybe you tried to apply it to net-2.6?

Yes, I did.

That's why people should always indicate what tree a patch is for in the subject line or similar.

#4 lore raw
Quoted 18 lines · David Miller

From: "Dimitrios Michailidis"<[email protected]>
Date: Fri, 2 Jul 2010 22:51:17 -0700

Quoted 15 lines
Quoted 14 lines

From: Denis Kirjanov<[email protected]>
Date: Thu, 1 Jul 2010 09:45:52 +0000

Quoted 4 lines

Use kfree_skb for skb pointers

Acked-by Dimitris Michailidis<[email protected]>
Signed-off-by Denis Kirjanov<[email protected]>

The code is completely different in this part of the driver now, this patch does not apply.

In fact there is no reference to the string "kfree" at all in the l2t.c file of the cxgb4 driver :)

Quoted 9 lines
Quoted 3 lines

This patch is for net-next and it should apply there, I see the wrong kfree (there's only one kfree). Denis didn't mention net-next, maybe you tried to apply it to net-2.6?

Yes, I did.

That's why people should always indicate what tree a patch is for in the subject line or similar.

Yes, I'll be more accurate next time.

Thanks.