edac: mpc85xx: Fix MPC85xx dependency
PATCH 1/2 edac: mpc85xx: Fix MPC85xx dependency
Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the driver became non-selectable.
This patch fixes the issue by switching to PPC_85xx symbol.
--- drivers/edac/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/edac/Kconfig +1 -1
@@ -209,7 +209,7 @@ config EDAC_I5100 config EDAC_MPC85XX tristate "Freescale MPC83xx / MPC85xx" - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx) + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx) help Support for error detection and correction on the Freescale MPC8349, MPC8560, MPC8540, MPC8548
Signature · 1 line
1.7.0.5
Quoted 3 lines · On Fri, 2 Jul 2010 16:41:11 +0400 Anton Vorontsov <[email protected]> wrote:
Since commit
5753c082f66eca5be81f6bda85c1718c5eea6ada("powerpc/85xx:Kconfigcleanup"), there is no MPC85xxKconfigsymbol anymore, so the driver became non-selectable.
hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline six months ago. How come nobody noticed?
Quoted 12 lines
This patch fixes the issue by switching to
PPC_85xxsymbol.Signed-off-by Anton Vorontsov <[email protected]>--- drivers/edac/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/edac/Kconfig +0
-0
drivers/edac/Kconfig config EDAC_I5100 · line 215
Quoted 8 lines
drivers/edac/Kconfig +1
-1@@ -209,7 +209,7 @@ config EDAC_I5100 config EDAC_MPC85XX tristate "Freescale MPC83xx / MPC85xx" - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx) + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx) help Support for error detection and correction on the Freescale MPC8349, MPC8560, MPC8540, MPC8548
I suppose we shold scoot this into 2.6.35 and mark it for -stable backporting. All very odd.
Quoted 9 lines · Andrew Morton
Quoted 3 lines · On Fri, 2 Jul 2010 16:41:11 +0400 Anton Vorontsov <[email protected]> wrote:
Since commit
5753c082f66eca5be81f6bda85c1718c5eea6ada("powerpc/85xx:Kconfigcleanup"), there is no MPC85xxKconfigsymbol anymore, so the driver became non-selectable.hm.
5753c082f66eca5be81f6bda85c1718c5eea6adagot merged into mainline six months ago. How come nobody noticed?
Dunno. Well, it's hard to notice these sorts of things until somebody actually needs this driver on MPC85xx platform. :-)
Quoted 4 lines
Quoted 4 lines
This patch fixes the issue by switching to
PPC_85xxsymbol.Signed-off-by Anton Vorontsov <[email protected]>---
[...]
Quoted 8 lines
drivers/edac/Kconfig config EDAC_I5100 · line 215
Quoted 5 lines
drivers/edac/Kconfig +1
-1- depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx) + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx) help Support for error detection and correction on the Freescale MPC8349, MPC8560, MPC8540, MPC8548I suppose we shold scoot this into 2.6.35 and mark it for -stable backporting. All very odd.
Yeah, -stable 2.6.{33,34} sounds good.
Thanks.
Quoted 28 lines · Anton Vorontsov
Quoted 9 lines · Andrew Morton
Quoted 3 lines · On Fri, 2 Jul 2010 16:41:11 +0400 Anton Vorontsov <[email protected]> wrote:
Since commit
5753c082f66eca5be81f6bda85c1718c5eea6ada("powerpc/85xx:Kconfigcleanup"), there is no MPC85xxKconfigsymbol anymore, so the driver became non-selectable.hm.
5753c082f66eca5be81f6bda85c1718c5eea6adagot merged into mainline six months ago. How come nobody noticed?Dunno. Well, it's hard to notice these sorts of things until somebody actually needs this driver on MPC85xx platform. :-)
Quoted 4 lines
Quoted 4 lines
This patch fixes the issue by switching to
PPC_85xxsymbol.Signed-off-by Anton Vorontsov <[email protected]>---
[...]
Quoted 8 lines
Quoted 5 lines
drivers/edac/Kconfig +1
-1- depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx) + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)help Support for error detection and correction on the Freescale MPC8349, MPC8560, MPC8540, MPC8548I suppose we shold scoot this into 2.6.35 and mark it for -stable backporting. All very odd.
Quoted 3 lines
Yeah, -stable 2.6.{33,34} sounds good.
Thanks.
we should add this to mpc85xx_defconfig so we build by default.
- k