cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

PATCH New pieterg 3 participants 8 messages Jul 8, 2010 – Jul 12, 2010

Share & tools

pieterg

author

2010-07-08 17:04 UTC #0 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

An embedded and charset-unspecified text was scrubbed...
Name: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100708/12fcc7a6/attachment.ksh>

Eric Miao

2010-07-09 08:02 UTC #1 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 15 lines · pieterg

Signed-off-by pieter <[email protected]>
---
?arch/arm/mach-pxa/cpufreq-pxa3xx.c | ? 13 ++++++++++++- ?1 files changed, 12 insertions(+), 1 deletions(-)
arch/arm/mach-pxa/cpufreq-pxa3xx.c +0 -0
index 27fa329..8cc10c3 100644
@@ -76,6 +76,14 @@ static struct pxa3xx_freq_info pxa300_freqs[] = {
? ? ? ?OP(624, 24, 2, 208, 260, 208, 312, 3, 1375, 1400), /* 624MHz */ ?};

Quoted 6 lines

+static struct pxa3xx_freq_info pxa310_freqs[] = {
+ ? ? ? /* ?CPU XL XN ?HSS DMEM SMEM SRAM DFI VCC_CORE VCC_SRAM */
+ ? ? ? OP(104, ?8, 1, 104, 260, ?78, 104, 3, 1000, 1100), /* 104MHz */
+ ? ? ? OP(208, 16, 1, 104, 260, 104, 156, 2, 1000, 1100), /* 208MHz */
+ ? ? ? OP(416, 16, 2, 156, 260, 104, 208, 2, 1100, 1200), /* 416MHz */
+ ? ? ? OP(624, 24, 2, 312, 260, 208, 312, 3, 1375, 1400), /* 624MHz */

What's wrong with 208MHz HSS on PXA310?

Quoted 28 lines

arch/arm/mach-pxa/cpufreq-pxa3xx.c +2 -0
+};
+
?static struct pxa3xx_freq_info pxa320_freqs[] = {
? ? ? ?/* ?CPU XL XN ?HSS DMEM SMEM SRAM DFI VCC_CORE VCC_SRAM */ ? ? ? ?OP(104, ?8, 1, 104, 260, ?78, 104, 3, 1000, 1100), /* 104MHz */
arch/arm/mach-pxa/cpufreq-pxa3xx.c +0 -0
@@ -214,9 +222,12 @@ static __init int pxa3xx_cpufreq_init(struct
 cpufreq_policy *policy)
? ? ? ?policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */ ? ? ? ?policy->cur = policy->min = policy->max = get_clk_frequency_khz(0);
- ? ? ? if (cpu_is_pxa300() || cpu_is_pxa310())
+ ? ? ? if (cpu_is_pxa300())
? ? ? ? ? ? ? ?ret = setup_freqs_table(policy, ARRAY_AND_SIZE(pxa300_freqs));
+ ? ? ? if (cpu_is_pxa310())
+ ? ? ? ? ? ? ? ret = setup_freqs_table(policy, ARRAY_AND_SIZE(pxa310_freqs)); +
? ? ? ?if (cpu_is_pxa320())
? ? ? ? ? ? ? ?ret = setup_freqs_table(policy, ARRAY_AND_SIZE(pxa320_freqs));
--
1.6.5.rc1.44.ga1675
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

pieterg

author

2010-07-09 08:31 UTC #2 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 1 line · On Friday 09 July 2010 10:02:16 Eric Miao wrote:

What's wrong with 208MHz HSS on PXA310?

I haven't done any benchmarking, but Marvell found it worth to introduce 312MHz for the pxa310. (I assume it might have something to do with the video accelerator, which is unique to the pxa310).

And to me it makes sense to use the highest supported speeds in the top cpufreq entry.

Rgds, Pieter

Igor Grinberg

2010-07-11 07:14 UTC #3 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 12 lines · pieterg

Quoted 2 lines · On Friday 09 July 2010 10:02:16 Eric Miao wrote:
What's wrong with 208MHz HSS on PXA310?
I haven't done any benchmarking, but Marvell found it worth to introduce 312MHz for the pxa310. (I assume it might have something to do with the video accelerator, which is unique to the pxa310).
And to me it makes sense to use the highest supported speeds in the top cpufreq entry.

According to Marvell's PXA3xx Specification Update document (page 68 - SCr#3), the above is correct starting from silicon revision A2. What about earlier revisions? Shouldn't we support all of them?

Quoted 8 lines

Rgds, Pieter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 2 lines

Regards,
Igor.

pieterg

author

2010-07-12 08:37 UTC #4 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 8 lines · On Sunday 11 July 2010 09:14:22 Igor Grinberg wrote:

Quoted 7 lines · pieterg
Quoted 1 line · On Friday 09 July 2010 10:02:16 Eric Miao wrote:
What's wrong with 208MHz HSS on PXA310?
I haven't done any benchmarking, but Marvell found it worth to introduce 312MHz for the pxa310. (I assume it might have something to do with the video accelerator, which is unique to the pxa310).

Quoted 6 lines

Quoted 2 lines
And to me it makes sense to use the highest supported speeds in the top cpufreq entry.
According to Marvell's PXA3xx Specification Update document (page 68 - SCr#3), the above is correct starting from silicon revision A2. What about earlier revisions? Shouldn't we support all of them?

OK, I missed that. In that case we should leave this one out.

Rgds, Pieter

Igor Grinberg

2010-07-12 09:13 UTC #5 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 12 lines · pieterg

Quoted 10 lines · On Sunday 11 July 2010 09:14:22 Igor Grinberg wrote:
Quoted 8 lines · pieterg
Quoted 2 lines · On Friday 09 July 2010 10:02:16 Eric Miao wrote:
What's wrong with 208MHz HSS on PXA310?
I haven't done any benchmarking, but Marvell found it worth to introduce 312MHz for the pxa310. (I assume it might have something to do with the video accelerator, which is unique to the pxa310).

Quoted 9 lines

Quoted 7 lines
Quoted 3 lines
And to me it makes sense to use the highest supported speeds in the top cpufreq entry.
According to Marvell's PXA3xx Specification Update document (page 68 - SCr#3), the above is correct starting from silicon revision A2. What about earlier revisions? Shouldn't we support all of them?
OK, I missed that. In that case we should leave this one out.

If you really want this to go, you can check the cpu stepping (cpuid register)
and fixup the table accordingly. Something like:

if (cpu_is_pxa310())

        ret = setup_freqs_table(policy, (read_cpuid_id() & 0xf) ?

ARRAY_AND_SIZE(pxa310_freqs) :

ARRAY_AND_SIZE(pxa300_freqs));

but I don't know if Eric will like it ;)

Quoted 3 lines

Rgds, Pieter

Signature · 2 lines

Regards,
Igor.

Eric Miao

2010-07-12 09:29 UTC #6 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 29 lines · Igor Grinberg

Quoted 12 lines · pieterg
Quoted 10 lines · On Sunday 11 July 2010 09:14:22 Igor Grinberg wrote:
Quoted 8 lines · pieterg
Quoted 2 lines · On Friday 09 July 2010 10:02:16 Eric Miao wrote:
What's wrong with 208MHz HSS on PXA310?
I haven't done any benchmarking, but Marvell found it worth to introduce 312MHz for the pxa310. (I assume it might have something to do with the video accelerator, which is unique to the pxa310).
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines
And to me it makes sense to use the highest supported speeds in the top cpufreq entry.
According to Marvell's PXA3xx Specification Update document (page 68 - SCr#3), the above is correct starting from silicon revision A2. What about earlier revisions? Shouldn't we support all of them?
OK, I missed that. In that case we should leave this one out.
If you really want this to go, you can check the cpu stepping (cpuid register)
and fixup the table accordingly. Something like:

Quoted 9 lines

if (cpu_is_pxa310())
? ? ? ?ret = setup_freqs_table(policy, (read_cpuid_id() & 0xf) ?
ARRAY_AND_SIZE(pxa310_freqs) :
ARRAY_AND_SIZE(pxa300_freqs));
but I don't know if Eric will like it ;)

Nah, I was thinking of introducing a cpu_is_pxa310_a2() or something, but that's really hard to make generic, since for this case, we'd have to use cpu_is_pxa310_a2_or_above(), which is #!$!%!@#$

So to put it simple, I think a command line parameter would make more sense in this case. e.g. pxa310_use_312mhz.

Quoted 9 lines

Quoted 3 lines
Rgds, Pieter
--
Regards,
Igor.

Igor Grinberg

2010-07-12 10:20 UTC #7 lore raw

PATCH 1/5 cpufreq-pxa3xx: use HSIO 312MHz on the pxa310

Quoted 47 lines · Eric Miao

Quoted 35 lines · Igor Grinberg
Quoted 20 lines · pieterg
Quoted 17 lines · On Sunday 11 July 2010 09:14:22 Igor Grinberg wrote:
Quoted 14 lines · pieterg
Quoted 3 lines · On Friday 09 July 2010 10:02:16 Eric Miao wrote:
What's wrong with 208MHz HSS on PXA310?
I haven't done any benchmarking, but Marvell found it worth to introduce 312MHz for the pxa310. (I assume it might have something to do with the video accelerator, which is unique to the pxa310).
And to me it makes sense to use the highest supported speeds in the top cpufreq entry.
Quoted 8 lines
Quoted 5 lines
According to Marvell's PXA3xx Specification Update document (page 68 - SCr#3), the above is correct starting from silicon revision A2. What about earlier revisions? Shouldn't we support all of them?
OK, I missed that. In that case we should leave this one out.
If you really want this to go, you can check the cpu stepping (cpuid register)
and fixup the table accordingly. Something like:
Quoted 10 lines
if (cpu_is_pxa310())
       ret = setup_freqs_table(policy, (read_cpuid_id() & 0xf) ?
ARRAY_AND_SIZE(pxa310_freqs) :
ARRAY_AND_SIZE(pxa300_freqs));
but I don't know if Eric will like it ;)

Quoted 7 lines

Nah, I was thinking of introducing a cpu_is_pxa310_a2() or something, but that's really hard to make generic, since for this case, we'd have to use cpu_is_pxa310_a2_or_above(), which is #!$!%!@#$
So to put it simple, I think a command line parameter would make more sense in this case. e.g. pxa310_use_312mhz.

Indeed, command line parameter pxa310.hss=312/208 sounds good

Quoted 12 lines

Quoted 11 lines
Quoted 5 lines
Rgds, Pieter
--
Regards,
Igor.

Signature · 2 lines

Regards,
Igor.