Skip to contentSkip to conversation

cy8ctmg110: capacitive touchscreen support

PATCH In review Alan Cox 2 participants 3 messages Jul 9, 2010

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 cy8ctmg110: capacitive touchscreen support

From: Samuli Konttila <[email protected]>

Add support for the cy8ctmg110 capacitive touchscreen used on some embedded devices.

(Some clean up by Alan Cox)

- Moved the hardcoded GPIO lines into platform data

Signed-off-by Alan Cox <[email protected]>

---

 drivers/input/touchscreen/Kconfig         |   14 +
 drivers/input/touchscreen/Makefile        |    1 
 drivers/input/touchscreen/cy8ctmg110_ts.c |  389 +++++++++++++++++++++++++++++
 3 files changed, 404 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/touchscreen/cy8ctmg110_ts.c
drivers/input/touchscreen/Kconfig +14 -0
index 625e625..8393f47 100644
@@ -612,4 +612,18 @@ config TOUCHSCREEN_STMPE
 	  To compile this driver as a module, choose M here: the
 	  module will be called stmpe-ts.
 
+config TOUCHSCREEN_CY8CTMG110
+	tristate "cy8ctmg110 touchscreen"
+	depends on I2C
+	depends on GPIOLIB
+
+	help
+	  Say Y here if you have a cy8ctmg110 capacitive touchscreen on
+	  an AAVA device.
+
+	  If unsure, say N.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called cy8ctmg110_ts.
+
 endif
drivers/input/touchscreen/Makefile +1 -0
index 963fec2..662d066 100644
@@ -14,6 +14,7 @@ obj-$(CONFIG_TOUCHSCREEN_AD7879_SPI)	+= ad7879-spi.o
 obj-$(CONFIG_TOUCHSCREEN_ADS7846)	+= ads7846.o
 obj-$(CONFIG_TOUCHSCREEN_ATMEL_TSADCC)	+= atmel_tsadcc.o
 obj-$(CONFIG_TOUCHSCREEN_BITSY)		+= h3600_ts_input.o
+obj-$(CONFIG_TOUCHSCREEN_CY8CTMG110)    += cy8ctmg110_ts.o
 obj-$(CONFIG_TOUCHSCREEN_DYNAPRO)	+= dynapro.o
 obj-$(CONFIG_TOUCHSCREEN_HAMPSHIRE)	+= hampshire.o
 obj-$(CONFIG_TOUCHSCREEN_GUNZE)		+= gunze.o
drivers/input/touchscreen/cy8ctmg110_ts.c new file +389 -0

389 lines not on this page · raw message

maintainer
#1 lore raw
Quoted 9 lines · Alan Cox

From: Samuli Konttila <[email protected]>

Add support for the cy8ctmg110 capacitive touchscreen used on some embedded devices.

(Some clean up by Alan Cox)

- Moved the hardcoded GPIO lines into platform data

I still see GPIO lines hardcoded. Wrong changeset description?

drivers/input/touchscreen/cy8ctmg110_ts.c line 248

Quoted 4 lines
drivers/input/touchscreen/cy8ctmg110_ts.c new file +4 -0
+
+	hrtimer_init(&ts->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
+	ts->timer.function = cy8ctmg110_timer;
+

I doubt it compiles since you seem to have removed cy8ctmg110_timer().

Signature · 1 line
Dmitry
maintainer
#2 lore raw
Quoted 11 lines · Dmitry Torokhov
Quoted 9 lines · Alan Cox

From: Samuli Konttila <[email protected]>

Add support for the cy8ctmg110 capacitive touchscreen used on some embedded devices.

(Some clean up by Alan Cox)

- Moved the hardcoded GPIO lines into platform data

Quoted 9 lines

I still see GPIO lines hardcoded. Wrong changeset description?

drivers/input/touchscreen/cy8ctmg110_ts.c line 248

Quoted 4 lines
drivers/input/touchscreen/cy8ctmg110_ts.c new file +4 -0
+
+	hrtimer_init(&ts->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
+	ts->timer.function = cy8ctmg110_timer;
+

I doubt it compiles since you seem to have removed cy8ctmg110_timer().

Ah, see you sent the next version, ignore me then.

Signature · 1 line
Dmitry