Skip to contentSkip to conversation

ocfs2: Remove the redundant cpu_to_le64.

PATCH New Tao Ma 2 participants 2 messages Jul 8, 2010 – Jul 12, 2010 OCFS2

lore
Share & tools
lore

Tao Ma

author
#0 lore raw

PATCH 1/1 ocfs2: Remove the redundant cpu_to_le64.

In ocfs2_block_group_alloc, we set c_blkno by bg->bg_blkno. But actually bg->bg_blkno is already changed to little endian in ocfs2_block_group_fill. So remove the extra cpu_to_le64.

Reported-by Marcos Matsunaga <[email protected]>
Signed-off-by Tao Ma <[email protected]>
---
 fs/ocfs2/suballoc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/suballoc.c +1 -1
index 8e881b5..3b8f85b 100644
@@ -618,7 +618,7 @@ static int ocfs2_block_group_alloc(struct ocfs2_super *osb,
 		     le16_to_cpu(bg->bg_free_bits_count));
 	le32_add_cpu(&cl->cl_recs[alloc_rec].c_total,
 		     le16_to_cpu(bg->bg_bits));
-	cl->cl_recs[alloc_rec].c_blkno  = cpu_to_le64(bg->bg_blkno);
+	cl->cl_recs[alloc_rec].c_blkno = bg->bg_blkno;
 	if (le16_to_cpu(cl->cl_next_free_rec) < le16_to_cpu(cl->cl_count))
 		le16_add_cpu(&cl->cl_next_free_rec, 1);
Signature · 1 line
1.7.1.571.gba4d01
#1 lore raw

PATCH 1/1 ocfs2: Remove the redundant cpu_to_le64.

Quoted 6 lines · Tao Ma

In ocfs2_block_group_alloc, we set c_blkno by bg->bg_blkno. But actually bg->bg_blkno is already changed to little endian in ocfs2_block_group_fill. So remove the extra cpu_to_le64.

Reported-by Marcos Matsunaga <[email protected]>
Signed-off-by Tao Ma <[email protected]>

This patch is now in the fixes branch of ocfs2.git.

Joel

Signature · 7 lines
	f/8 and be there.

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127