Skip to contentSkip to conversation

never re-execute instruction with enabled tdp

PATCH Applied Gleb Natapov 2 participants 2 messages Jul 14, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 never re-execute instruction with enabled tdp

With tdp enabled we should get into emulator only when emulating io, so reexecution will always bring us back into emulator.

arch/x86/kvm/x86.c +3 -0
index fb08316..86c8102 100644
@@ -3936,6 +3936,9 @@ static bool reexecute_instruction(struct kvm_vcpu *vcpu, gva_t gva)
 {
 	gpa_t gpa;
 
+	if (tdp_enabled)
+		return false;
+
 	/*
 	 * if emulation was due to access to shadowed page table
 	 * and it failed try to unshadow page and re-entetr the

--
Gleb.

#1 lore raw

arch/x86/kvm/x86.c

Quoted 5 lines · Gleb Natapov

With tdp enabled we should get into emulator only when emulating io, so reexecution will always bring us back into emulator.

arch/x86/kvm/x86.c +0 -0

Applied, thanks.