Skip to contentSkip to conversation

wm8727: add a missing return in wm8727_platform_probe

PATCH In review Axel Lin 3 participants 3 messages Jul 14, 2010

Subsystems (3)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 wm8727: add a missing return in wm8727_platform_probe

otherwise the error path will always be executed.

---
 sound/soc/codecs/wm8727.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/codecs/wm8727.c +2 -0
index 1072621..9d1df26 100644
@@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
 		goto err_codec;
 	}
 
+	return 0;
+
 err_codec:
 	snd_soc_unregister_codec(codec);
 err:
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Axel Lin

otherwise the error path will always be executed.

---
 sound/soc/codecs/wm8727.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/codecs/wm8727.c +0 -0
index 1072621..9d1df26 100644

sound/soc/codecs/wm8727.c static __devinit int wm8727_platform_probe(struct platform_device *pdev) · line 134

Quoted 8 lines
sound/soc/codecs/wm8727.c +2 -0
@@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
 		goto err_codec;
 	}
 
+	return 0;
+
 err_codec:
 	snd_soc_unregister_codec(codec);
 err:

Both

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk