Skip to contentSkip to conversation

mlx4_core: module param to limit msix vec allocation

PATCH/RESEND Arthur Kepner 1 participant 1 message Jul 15, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

The mlx4_core driver allocates 'nreq' msix vectors (and irqs), where:

nreq = min_t(int, dev->caps.num_eqs - dev->caps.reserved_eqs,

               num_possible_cpus() + 1);

ConnectX HCAs support 512 event queues (4 reserved). On a system with enough processors, we get:

mlx4_core 0006:01:00.0: Requested 508 vectors, but only 256 MSI-X vectors available, trying again

Further attempts (by other drivers) to allocate interrupts fail, because mlx4_core got 'em all.

How about this?

---

 main.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/net/mlx4/main.c +7 -1
index e3e0d54..0a316d0 100644
@@ -68,6 +68,10 @@ static int msi_x = 1;
 module_param(msi_x, int, 0444);
 MODULE_PARM_DESC(msi_x, "attempt to use MSI-X if nonzero");
 
+static int max_msi_x_vec = 64;
+module_param(max_msi_x_vec, int, 0444);
+MODULE_PARM_DESC(max_msi_x_vec, "max MSI-X vectors we'll attempt to allocate");
+
 #else /* CONFIG_PCI_MSI */
 
 #define msi_x (0)
@@ -968,8 +972,10 @@ static void mlx4_enable_msi_x(struct mlx4_dev *dev)
 	int i;
 
 	if (msi_x) {
+		nreq = min_t(int, num_possible_cpus() + 1, max_msi_x_vec);
 		nreq = min_t(int, dev->caps.num_eqs - dev->caps.reserved_eqs,
-			     num_possible_cpus() + 1);
+			     nreq);
+
 		entries = kcalloc(nreq, sizeof *entries, GFP_KERNEL);
 		if (!entries)
 			goto no_msi;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html