Skip to contentSkip to conversation

arcnet: fix signed bug in probe function

PATCH Applied Dan Carpenter 2 participants 2 messages Jul 17, 2010 – Jul 18, 2010

Subsystems (4)
Networking Network drivers Kernel janitors Arcnet network layer
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 arcnet: fix signed bug in probe function

probe_irq_off() returns the first irq found or if two irqs are found then it returns the negative of the first irq found. We can cast dev->irq to an int so that the test for negative values works.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/arcnet/com20020-isa.c +2 -2
index 0402da3..3727282 100644
@@ -90,14 +90,14 @@ static int __init com20020isa_probe(struct net_device *dev)
 		outb(0, _INTMASK);
 		dev->irq = probe_irq_off(airqmask);
 
-		if (dev->irq <= 0) {
+		if ((int)dev->irq <= 0) {
 			BUGMSG(D_INIT_REASONS, "Autoprobe IRQ failed first time\n");
 			airqmask = probe_irq_on();
 			outb(NORXflag, _INTMASK);
 			udelay(5);
 			outb(0, _INTMASK);
 			dev->irq = probe_irq_off(airqmask);
-			if (dev->irq <= 0) {
+			if ((int)dev->irq <= 0) {
 				BUGMSG(D_NORMAL, "Autoprobe IRQ failed.\n");
 				err = -ENODEV;
 				goto out;
drivers/net/arcnet/com90io.c +1 -1
index 4cb4018..eb27976 100644
@@ -213,7 +213,7 @@ static int __init com90io_probe(struct net_device *dev)
 		outb(0, _INTMASK);
 		dev->irq = probe_irq_off(airqmask);
 
-		if (dev->irq <= 0) {
+		if ((int)dev->irq <= 0) {
 			BUGMSG(D_INIT_REASONS, "Autoprobe IRQ failed\n");
 			goto err_out;
 		}
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Sat, 17 Jul 2010 19:21:28 +0200

Quoted 5 lines

probe_irq_off() returns the first irq found or if two irqs are found then it returns the negative of the first irq found. We can cast dev->irq to an int so that the test for negative values works.

Signed-off-by Dan Carpenter <[email protected]>

Applied.