Skip to contentSkip to conversation

I2C driver supporting Moorestown and Medfield platform

PATCH In review Alan Cox 2 participants 3 messages Jul 19, 2010 2 messages not in the archive I2C subsystem host drivers

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 I2C driver supporting Moorestown and Medfield platform

From: Wen Wang <[email protected]>

Initial release of the driver.

Some clean up table removal by Alan Cox

---

 drivers/i2c/busses/Kconfig    |    9 
 drivers/i2c/busses/Makefile   |    1 
 drivers/i2c/busses/i2c-mrst.c |  902 +++++++++++++++++++++++++++++++++++++++++
 drivers/i2c/busses/i2c-mrst.h |  269 ++++++++++++
 4 files changed, 1181 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-mrst.c
 create mode 100644 drivers/i2c/busses/i2c-mrst.h
drivers/i2c/busses/Kconfig +9 -0
index 29e01f6..ea0100e 100644
@@ -420,6 +420,15 @@ config I2C_IXP2000
 	  This driver is deprecated and will be dropped soon. Use i2c-gpio
 	  instead.
 
+config I2C_MRST
+	tristate "Intel Moorestown/Medfield Platform I2C controller"
+	help
+	  Say Y here if you have an Intel Moorestown/Medfield platform I2C
+	  controller.
+
+	  This support is also available as a module. If so, the module
+	  will be called i2c-mrst.
+
 config I2C_MPC
 	tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx"
 	depends on PPC32
drivers/i2c/busses/Makefile +1 -0
index 936880b..0b9aa00 100644
@@ -40,6 +40,7 @@ obj-$(CONFIG_I2C_IBM_IIC)	+= i2c-ibm_iic.o
 obj-$(CONFIG_I2C_IMX)		+= i2c-imx.o
 obj-$(CONFIG_I2C_IOP3XX)	+= i2c-iop3xx.o
 obj-$(CONFIG_I2C_IXP2000)	+= i2c-ixp2000.o
+obj-$(CONFIG_I2C_MRST)		+= i2c-mrst.o
 obj-$(CONFIG_I2C_MPC)		+= i2c-mpc.o
 obj-$(CONFIG_I2C_MV64XXX)	+= i2c-mv64xxx.o
 obj-$(CONFIG_I2C_NOMADIK)	+= i2c-nomadik.o
drivers/i2c/busses/i2c-mrst.c new file +902 -0

902 lines not on this page · raw message

drivers/i2c/busses/i2c-mrst.h new file +269 -0

269 lines not on this page · raw message

A message that is not in the archive (sent off-list or not yet received): 20100719101724.31685.76712.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

#2 lore raw

Hi Alan,

Quoted 10 lines · Alan Cox

From: Wen Wang <[email protected]>

Initial release of the driver.

Some clean up table removal by Alan Cox

---

Quoted 7 lines
 drivers/i2c/busses/Kconfig    |    9 
 drivers/i2c/busses/Makefile   |    1 
 drivers/i2c/busses/i2c-mrst.c |  902 +++++++++++++++++++++++++++++++++++++++++
 drivers/i2c/busses/i2c-mrst.h |  269 ++++++++++++
 4 files changed, 1181 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-mrst.c
 create mode 100644 drivers/i2c/busses/i2c-mrst.h

I already reviewed this driver back in June 2009:
http://marc.info/?l=linux-i2c&m=124506668112908&w=2

I hope that all my concerns back then have been addressed?

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#4 lore raw
Quoted 4 lines

I already reviewed this driver back in June 2009:
http://marc.info/?l=linux-i2c&m=124506668112908&w=2

I hope that all my concerns back then have been addressed?

Ah thanks - I wasn't aware an older version of this had been reviewed (I'm arriving to this stuff rather after last June). Some of the points you raise have, some haven't. I'll send you a new revision with those addressed as well.

Alan