pxa/spitz: remove unused declarations

PATCH New Eric Miao 2 participants 10 messages Jul 19, 2010

Subsystems (4)

Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support Mmp support

lore

Share & tools

lore

Eric Miao

author

2010-07-19 10:58 UTC #0 lore raw

PATCH 1/9 pxa/spitz: remove unused declarations

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-pxa/include/mach/spitz.h |    8 --------
 arch/arm/mach-pxa/spitz.c              |    3 ---
 2 files changed, 0 insertions(+), 11 deletions(-)

arch/arm/mach-pxa/include/mach/spitz.h +0 -8

index fa1998c..dc1ff25 100644
@@ -181,11 +181,3 @@
 #define SPITZ_IRQ_GPIO_CF2_IRQ        IRQ_GPIO(SPITZ_GPIO_CF2_IRQ)
 #define SPITZ_IRQ_GPIO_nSD_INT        IRQ_GPIO(SPITZ_GPIO_nSD_INT)
 #define SPITZ_IRQ_GPIO_nSD_DETECT     IRQ_GPIO(SPITZ_GPIO_nSD_DETECT)
-
-/*
- * Shared data structures
- */
-extern struct platform_device spitzscoop_device;
-extern struct platform_device spitzscoop2_device;
-extern struct platform_device spitzssp_device;
-extern struct sharpsl_charger_machinfo spitz_pm_machinfo;

arch/arm/mach-pxa/spitz.c +0 -3

index c1048a3..ddf7a11 100644
@@ -242,9 +242,6 @@ static struct scoop_pcmcia_config spitz_pcmcia_config = {
 	.power_ctrl   = spitz_pcmcia_pwr,
 };
 
-EXPORT_SYMBOL(spitzscoop_device);
-EXPORT_SYMBOL(spitzscoop2_device);
-
 /*
  * Spitz Keyboard Device
  */

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:58 UTC #1 lore raw

PATCH 2/9 pxa/corgi: remove unused declarations of corgiscoop_device

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-pxa/corgi.c              |    2 --
 arch/arm/mach-pxa/include/mach/corgi.h |    5 -----
 2 files changed, 0 insertions(+), 7 deletions(-)

arch/arm/mach-pxa/corgi.c +0 -2

index 51ffa6a..34ddc3a 100644
@@ -185,8 +185,6 @@ static struct scoop_pcmcia_config corgi_pcmcia_config = {
 	.num_devs     = 1,
 };
 
-EXPORT_SYMBOL(corgiscoop_device);
-
 static struct w100_mem_info corgi_fb_mem = {
 	.ext_cntl          = 0x00040003,
 	.sdram_mode_reg    = 0x00650021,

arch/arm/mach-pxa/include/mach/corgi.h +0 -5

index 585970e..0011055 100644
@@ -109,10 +109,5 @@
 #define CORGI_GPIO_BACKLIGHT_CONT	(CORGI_SCOOP_GPIO_BASE + 7)
 #define CORGI_GPIO_MIC_BIAS		(CORGI_SCOOP_GPIO_BASE + 8)
 
-/*
- * Shared data structures
- */
-extern struct platform_device corgiscoop_device;
-
 #endif /* __ASM_ARCH_CORGI_H  */

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:58 UTC #2 lore raw

PATCH 3/9 pxa: use generic gpio_get_value() instead of READ_GPIO_BIT()

In reply to Eric Miao

READ_GPIO_BIT() is no way generic by accessing GPIO registers directly, replace it with gpio_get_value().

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-pxa/corgi_pm.c |    6 +++---
 arch/arm/mach-pxa/spitz_pm.c |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

arch/arm/mach-pxa/corgi_pm.c +3 -3

index a735205..41cf945 100644
@@ -134,11 +134,11 @@ unsigned long corgipm_read_devdata(int type)
 	case SHARPSL_STATUS_ACIN:
 		return ((GPLR(CORGI_GPIO_AC_IN) & GPIO_bit(CORGI_GPIO_AC_IN)) != 0);
 	case SHARPSL_STATUS_LOCK:
-		return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batlock);
+		return gpio_get_value(sharpsl_pm.machinfo->gpio_batlock);
 	case SHARPSL_STATUS_CHRGFULL:
-		return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batfull);
+		return gpio_get_value(sharpsl_pm.machinfo->gpio_batfull);
 	case SHARPSL_STATUS_FATAL:
-		return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_fatal);
+		return gpio_get_value(sharpsl_pm.machinfo->gpio_fatal);
 	case SHARPSL_ACIN_VOLT:
 		return sharpsl_pm_pxa_read_max1111(MAX1111_ACIN_VOLT);
 	case SHARPSL_BATT_TEMP:

arch/arm/mach-pxa/spitz_pm.c +3 -3

index b36f0ae..53103d3 100644
@@ -178,11 +178,11 @@ unsigned long spitzpm_read_devdata(int type)
 	case SHARPSL_STATUS_ACIN:
 		return (((~GPLR(SPITZ_GPIO_AC_IN)) & GPIO_bit(SPITZ_GPIO_AC_IN)) != 0);
 	case SHARPSL_STATUS_LOCK:
-		return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batlock);
+		return gpio_get_value(sharpsl_pm.machinfo->gpio_batlock);
 	case SHARPSL_STATUS_CHRGFULL:
-		return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batfull);
+		return gpio_get_value(sharpsl_pm.machinfo->gpio_batfull);
 	case SHARPSL_STATUS_FATAL:
-		return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_fatal);
+		return gpio_get_value(sharpsl_pm.machinfo->gpio_fatal);
 	case SHARPSL_ACIN_VOLT:
 		return sharpsl_pm_pxa_read_max1111(MAX1111_ACIN_VOLT);
 	case SHARPSL_BATT_TEMP:

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:58 UTC #3 lore raw

PATCH 4/9 pxa: removed mostly unused and confusing two sharpsl.h

In reply to Eric Miao

Only a small part of used code is moved into sharpsl_pm.h.

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-pxa/corgi.c                   |    3 +-
 arch/arm/mach-pxa/corgi_pm.c                |    3 +-
 arch/arm/mach-pxa/include/mach/sharpsl.h    |   35 ---------------------------
 arch/arm/mach-pxa/include/mach/sharpsl_pm.h |    9 +++++++
 arch/arm/mach-pxa/poodle.c                  |    2 -
 arch/arm/mach-pxa/sharpsl.h                 |   26 --------------------
 arch/arm/mach-pxa/sharpsl_pm.c              |    3 --
 arch/arm/mach-pxa/spitz.c                   |    2 +-
 arch/arm/mach-pxa/spitz_pm.c                |    3 +-
 9 files changed, 13 insertions(+), 73 deletions(-)
 delete mode 100644 arch/arm/mach-pxa/include/mach/sharpsl.h
 delete mode 100644 arch/arm/mach-pxa/sharpsl.h

arch/arm/mach-pxa/corgi.c +1 -2

index 34ddc3a..1e25337 100644
@@ -50,14 +50,13 @@
 #include <mach/udc.h>
 #include <mach/pxa2xx_spi.h>
 #include <mach/corgi.h>
-#include <mach/sharpsl.h>
+#include <mach/sharpsl_pm.h>
 
 #include <asm/mach/sharpsl_param.h>
 #include <asm/hardware/scoop.h>
 
 #include "generic.h"
 #include "devices.h"
-#include "sharpsl.h"
 
 static unsigned long corgi_pin_config[] __initdata = {
 	/* Static Memory I/O */

arch/arm/mach-pxa/corgi_pm.c +1 -2

index 41cf945..2903477 100644
@@ -23,12 +23,11 @@
 #include <asm/mach-types.h>
 #include <mach/hardware.h>
 
-#include <mach/sharpsl.h>
 #include <mach/corgi.h>
 #include <mach/pxa2xx-regs.h>
+#include <mach/sharpsl_pm.h>
 
 #include "generic.h"
-#include "sharpsl.h"
 
 #define SHARPSL_CHARGE_ON_VOLT         0x99  /* 2.9V */
 #define SHARPSL_CHARGE_ON_TEMP         0xe0  /* 2.9V */

arch/arm/mach-pxa/include/mach/sharpsl.h deleted +0 ~~-35~~

deleted file mode 100644
index 8242e14..0000000
@@ -1,35 +0,0 @@
-/*
- * SharpSL SSP Driver
- */
-
-unsigned long corgi_ssp_ads7846_putget(unsigned long);
-unsigned long corgi_ssp_ads7846_get(void);
-void corgi_ssp_ads7846_put(unsigned long data);
-void corgi_ssp_ads7846_lock(void);
-void corgi_ssp_ads7846_unlock(void);
-void corgi_ssp_lcdtg_send (unsigned char adrs, unsigned char data);
-void corgi_ssp_blduty_set(int duty);
-int corgi_ssp_max1111_get(unsigned long data);
-
-/*
- * SharpSL Touchscreen Driver
- */
-
-struct corgits_machinfo {
-	unsigned long (*get_hsync_invperiod)(void);
-	void (*put_hsync)(void);
-	void (*wait_hsync)(void);
-};
-
-
-/*
- * SharpSL Backlight
- */
-extern void corgibl_limit_intensity(int limit);
-extern void corgi_lcd_limit_intensity(int limit);
-
-
-/*
- * SharpSL Battery/PM Driver
- */
-extern void sharpsl_battery_kick(void);

arch/arm/mach-pxa/include/mach/sharpsl_pm.h +9 -0

index 1920dc6..905be67 100644
@@ -93,6 +93,8 @@ struct sharpsl_pm_status {
 
 extern struct sharpsl_pm_status sharpsl_pm;
 
+extern struct battery_thresh sharpsl_battery_levels_acin[];
+extern struct battery_thresh sharpsl_battery_levels_noac[];
 
 #define SHARPSL_LED_ERROR  2
 #define SHARPSL_LED_ON     1

@@ -101,4 +103,11 @@ extern struct sharpsl_pm_status sharpsl_pm;
 void sharpsl_battery_kick(void);
 void sharpsl_pm_led(int val);
 
+/* MAX1111 Channel Definitions */
+#define MAX1111_BATT_VOLT   4u
+#define MAX1111_BATT_TEMP   2u
+#define MAX1111_ACIN_VOLT   6u
+int sharpsl_pm_pxa_read_max1111(int channel);
+
+void corgi_lcd_limit_intensity(int limit);
 #endif

arch/arm/mach-pxa/poodle.c +0 -2

index f4abdaa..41c8948 100644
@@ -43,7 +43,6 @@
 #include <mach/irda.h>
 #include <mach/poodle.h>
 #include <mach/pxafb.h>
-#include <mach/sharpsl.h>
 #include <mach/pxa2xx_spi.h>
 #include <plat/i2c.h>

@@ -53,7 +52,6 @@
 
 #include "generic.h"
 #include "devices.h"
-#include "sharpsl.h"
 
 static unsigned long poodle_pin_config[] __initdata = {
 	/* I/O */

arch/arm/mach-pxa/sharpsl.h deleted +0 ~~-26~~

deleted file mode 100644
index 0cc1203..0000000
@@ -1,26 +0,0 @@
-/*
- * Copyright (c) 2004-2005 Richard Purdie
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- */
-
-#include <mach/sharpsl_pm.h>
-
-/*
- * SharpSL Battery/PM Driver
- */
-#define READ_GPIO_BIT(x)    (GPLR(x) & GPIO_bit(x))
-
-/* MAX1111 Channel Definitions */
-#define MAX1111_BATT_VOLT   4u
-#define MAX1111_BATT_TEMP   2u
-#define MAX1111_ACIN_VOLT   6u
-
-extern struct battery_thresh sharpsl_battery_levels_acin[];
-extern struct battery_thresh sharpsl_battery_levels_noac[];
-int sharpsl_pm_pxa_read_max1111(int channel);
-
-

arch/arm/mach-pxa/sharpsl_pm.c +0 -3

index d8c5301..8fed027 100644
@@ -29,11 +29,8 @@
 #include <mach/pm.h>
 #include <mach/pxa2xx-regs.h>
 #include <mach/regs-rtc.h>
-#include <mach/sharpsl.h>
 #include <mach/sharpsl_pm.h>
 
-#include "sharpsl.h"
-
 /*
  * Constants
  */

arch/arm/mach-pxa/spitz.c +1 -1

index ddf7a11..5153bf3 100644
@@ -44,10 +44,10 @@
 #include <mach/pxafb.h>
 #include <mach/pxa2xx_spi.h>
 #include <mach/spitz.h>
+#include <mach/sharpsl_pm.h>
 
 #include "generic.h"
 #include "devices.h"
-#include "sharpsl.h"
 
 static unsigned long spitz_pin_config[] __initdata = {
 	/* Chip Selects */

arch/arm/mach-pxa/spitz_pm.c +1 -2

index 53103d3..7fe7406 100644
@@ -22,11 +22,10 @@
 #include <asm/mach-types.h>
 #include <mach/hardware.h>
 
-#include <mach/sharpsl.h>
 #include <mach/spitz.h>
 #include <mach/pxa27x.h>
+#include <mach/sharpsl_pm.h>
 
-#include "sharpsl.h"
 #include "generic.h"
 
 #define SHARPSL_CHARGE_ON_VOLT         0x99  /* 2.9V */

Signature · 1 line

1.7.1

Marek Vasut

2010-07-19 14:54 UTC #4 lore raw

PATCH 4/9 pxa: removed mostly unused and confusing two sharpsl.h

Dne Po 19. ?ervence 2010 12:58:59 Eric Miao napsal(a):

Quoted 1 line

Only a small part of used code is moved into sharpsl_pm.h.

Hey, please don't forget to merge those two zaurus patches I posted. I can take C3200 with me tomorrow if you want. I can take C3000 with me too, but we'll have to figure out how to return the original flash back (as it's not mine).

Or maybe we should just avoid talking about/doing any work ... :)

Quoted 223 lines

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-pxa/corgi.c                   |    3 +-
 arch/arm/mach-pxa/corgi_pm.c                |    3 +-
 arch/arm/mach-pxa/include/mach/sharpsl.h    |   35
--------------------------- arch/arm/mach-pxa/include/mach/sharpsl_pm.h | 
  9 +++++++
 arch/arm/mach-pxa/poodle.c                  |    2 -
 arch/arm/mach-pxa/sharpsl.h                 |   26 --------------------
 arch/arm/mach-pxa/sharpsl_pm.c              |    3 --
 arch/arm/mach-pxa/spitz.c                   |    2 +-
 arch/arm/mach-pxa/spitz_pm.c                |    3 +-
 9 files changed, 13 insertions(+), 73 deletions(-)
 delete mode 100644 arch/arm/mach-pxa/include/mach/sharpsl.h
 delete mode 100644 arch/arm/mach-pxa/sharpsl.h

arch/arm/mach-pxa/corgi.c +1 -2

index 34ddc3a..1e25337 100644
@@ -50,14 +50,13 @@
 #include <mach/udc.h>
 #include <mach/pxa2xx_spi.h>
 #include <mach/corgi.h>
-#include <mach/sharpsl.h>
+#include <mach/sharpsl_pm.h>
 
 #include <asm/mach/sharpsl_param.h>
 #include <asm/hardware/scoop.h>
 
 #include "generic.h"
 #include "devices.h"
-#include "sharpsl.h"
 
 static unsigned long corgi_pin_config[] __initdata = {
 	/* Static Memory I/O */

arch/arm/mach-pxa/corgi_pm.c +1 -2

index 41cf945..2903477 100644
@@ -23,12 +23,11 @@
 #include <asm/mach-types.h>
 #include <mach/hardware.h>
 
-#include <mach/sharpsl.h>
 #include <mach/corgi.h>
 #include <mach/pxa2xx-regs.h>
+#include <mach/sharpsl_pm.h>
 
 #include "generic.h"
-#include "sharpsl.h"
 
 #define SHARPSL_CHARGE_ON_VOLT         0x99  /* 2.9V */
 #define SHARPSL_CHARGE_ON_TEMP         0xe0  /* 2.9V */

(quoted diff) +0 -0

b/arch/arm/mach-pxa/include/mach/sharpsl.h deleted file mode 100644 index 8242e14..0000000

arch/arm/mach-pxa/include/mach/sharpsl.h deleted +0 ~~-35~~

@@ -1,35 +0,0 @@
-/*
- * SharpSL SSP Driver
- */
-
-unsigned long corgi_ssp_ads7846_putget(unsigned long);
-unsigned long corgi_ssp_ads7846_get(void);
-void corgi_ssp_ads7846_put(unsigned long data);
-void corgi_ssp_ads7846_lock(void);
-void corgi_ssp_ads7846_unlock(void);
-void corgi_ssp_lcdtg_send (unsigned char adrs, unsigned char data);
-void corgi_ssp_blduty_set(int duty);
-int corgi_ssp_max1111_get(unsigned long data);
-
-/*
- * SharpSL Touchscreen Driver
- */
-
-struct corgits_machinfo {
-	unsigned long (*get_hsync_invperiod)(void);
-	void (*put_hsync)(void);
-	void (*wait_hsync)(void);
-};
-
-
-/*
- * SharpSL Backlight
- */
-extern void corgibl_limit_intensity(int limit);
-extern void corgi_lcd_limit_intensity(int limit);
-
-
-/*
- * SharpSL Battery/PM Driver
- */
-extern void sharpsl_battery_kick(void);

(quoted diff) +0 -0

b/arch/arm/mach-pxa/include/mach/sharpsl_pm.h index 1920dc6..905be67 100644

arch/arm/mach-pxa/include/mach/sharpsl_pm.h +9 -0

@@ -93,6 +93,8 @@ struct sharpsl_pm_status {
 
 extern struct sharpsl_pm_status sharpsl_pm;
 
+extern struct battery_thresh sharpsl_battery_levels_acin[];
+extern struct battery_thresh sharpsl_battery_levels_noac[];
 
 #define SHARPSL_LED_ERROR  2
 #define SHARPSL_LED_ON     1

@@ -101,4 +103,11 @@ extern struct sharpsl_pm_status sharpsl_pm;
 void sharpsl_battery_kick(void);
 void sharpsl_pm_led(int val);
 
+/* MAX1111 Channel Definitions */
+#define MAX1111_BATT_VOLT   4u
+#define MAX1111_BATT_TEMP   2u
+#define MAX1111_ACIN_VOLT   6u
+int sharpsl_pm_pxa_read_max1111(int channel);
+
+void corgi_lcd_limit_intensity(int limit);
 #endif

arch/arm/mach-pxa/poodle.c +0 -2

index f4abdaa..41c8948 100644
@@ -43,7 +43,6 @@
 #include <mach/irda.h>
 #include <mach/poodle.h>
 #include <mach/pxafb.h>
-#include <mach/sharpsl.h>
 #include <mach/pxa2xx_spi.h>
 #include <plat/i2c.h>

@@ -53,7 +52,6 @@
 
 #include "generic.h"
 #include "devices.h"
-#include "sharpsl.h"
 
 static unsigned long poodle_pin_config[] __initdata = {
 	/* I/O */

arch/arm/mach-pxa/sharpsl.h deleted +0 ~~-26~~

deleted file mode 100644
index 0cc1203..0000000
@@ -1,26 +0,0 @@
-/*
- * Copyright (c) 2004-2005 Richard Purdie
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- */
-
-#include <mach/sharpsl_pm.h>
-
-/*
- * SharpSL Battery/PM Driver
- */
-#define READ_GPIO_BIT(x)    (GPLR(x) & GPIO_bit(x))
-
-/* MAX1111 Channel Definitions */
-#define MAX1111_BATT_VOLT   4u
-#define MAX1111_BATT_TEMP   2u
-#define MAX1111_ACIN_VOLT   6u
-
-extern struct battery_thresh sharpsl_battery_levels_acin[];
-extern struct battery_thresh sharpsl_battery_levels_noac[];
-int sharpsl_pm_pxa_read_max1111(int channel);
-
-

(quoted diff) +0 -0

b/arch/arm/mach-pxa/sharpsl_pm.c index d8c5301..8fed027 100644

arch/arm/mach-pxa/sharpsl_pm.c +0 -3

@@ -29,11 +29,8 @@
 #include <mach/pm.h>
 #include <mach/pxa2xx-regs.h>
 #include <mach/regs-rtc.h>
-#include <mach/sharpsl.h>
 #include <mach/sharpsl_pm.h>
 
-#include "sharpsl.h"
-
 /*
  * Constants
  */

arch/arm/mach-pxa/spitz.c +1 -1

index ddf7a11..5153bf3 100644
@@ -44,10 +44,10 @@
 #include <mach/pxafb.h>
 #include <mach/pxa2xx_spi.h>
 #include <mach/spitz.h>
+#include <mach/sharpsl_pm.h>
 
 #include "generic.h"
 #include "devices.h"
-#include "sharpsl.h"
 
 static unsigned long spitz_pin_config[] __initdata = {
 	/* Chip Selects */

arch/arm/mach-pxa/spitz_pm.c +1 -2

index 53103d3..7fe7406 100644
@@ -22,11 +22,10 @@
 #include <asm/mach-types.h>
 #include <mach/hardware.h>
 
-#include <mach/sharpsl.h>
 #include <mach/spitz.h>
 #include <mach/pxa27x.h>
+#include <mach/sharpsl_pm.h>
 
-#include "sharpsl.h"
 #include "generic.h"
 
 #define SHARPSL_CHARGE_ON_VOLT         0x99  /* 2.9V */

Eric Miao

author

2010-07-19 10:59 UTC #5 lore raw

PATCH 5/9 mmp: remove never supported .boot_params for MMP

In reply to Eric Miao

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-mmp/aspenite.c      |    2 --
 arch/arm/mach-mmp/avengers_lite.c |    1 -
 arch/arm/mach-mmp/flint.c         |    1 -
 arch/arm/mach-mmp/jasper.c        |    1 -
 arch/arm/mach-mmp/tavorevb.c      |    1 -
 arch/arm/mach-mmp/ttc_dkb.c       |    1 -
 6 files changed, 0 insertions(+), 7 deletions(-)

arch/arm/mach-mmp/aspenite.c +0 -2

index 244655d..1721c54 100644
@@ -150,7 +150,6 @@ static void __init common_init(void)
 
 MACHINE_START(ASPENITE, "PXA168-based Aspenite Development Platform")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = pxa168_init_irq,

@@ -160,7 +159,6 @@ MACHINE_END
 
 MACHINE_START(ZYLONITE2, "PXA168-based Zylonite2 Development Platform")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = pxa168_init_irq,

arch/arm/mach-mmp/avengers_lite.c +0 -1

index 8c3fa5d..2906c9e 100644
@@ -42,7 +42,6 @@ static void __init avengers_lite_init(void)
 
 MACHINE_START(AVENGERS_LITE, "PXA168 Avengers lite Development Platform")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = pxa168_init_irq,

arch/arm/mach-mmp/flint.c +0 -1

index 4ec7709..e77bb0a 100644
@@ -114,7 +114,6 @@ static void __init flint_init(void)
 
 MACHINE_START(FLINT, "Flint Development Platform")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = mmp2_init_irq,

arch/arm/mach-mmp/jasper.c +0 -1

index d77dd41..8e2b171 100644
@@ -135,7 +135,6 @@ static void __init jasper_init(void)
 
 MACHINE_START(MARVELL_JASPER, "Jasper Development Platform")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = mmp2_init_irq,

arch/arm/mach-mmp/tavorevb.c +0 -1

index 0e0c922..b8b38aa 100644
@@ -100,7 +100,6 @@ static void __init tavorevb_init(void)
 
 MACHINE_START(TAVOREVB, "PXA910 Evaluation Board (aka TavorEVB)")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = pxa910_init_irq,

arch/arm/mach-mmp/ttc_dkb.c +0 -1

index b22dec4..ba3ce41 100644
@@ -123,7 +123,6 @@ static void __init ttc_dkb_init(void)
 
 MACHINE_START(TTC_DKB, "PXA910-based TTC_DKB Development Platform")
 	.phys_io        = APB_PHYS_BASE,
-	.boot_params    = 0x00000100,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
 	.map_io		= pxa_map_io,
 	.init_irq       = pxa910_init_irq,

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:59 UTC #6 lore raw

PATCH 6/9 mmp: rename pxa_map_io() to mmp_map_io()

In reply to Eric Miao

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-mmp/aspenite.c      |    4 ++--
 arch/arm/mach-mmp/avengers_lite.c |    2 +-
 arch/arm/mach-mmp/common.c        |    2 +-
 arch/arm/mach-mmp/common.h        |    2 +-
 arch/arm/mach-mmp/flint.c         |    2 +-
 arch/arm/mach-mmp/jasper.c        |    2 +-
 arch/arm/mach-mmp/tavorevb.c      |    2 +-
 arch/arm/mach-mmp/ttc_dkb.c       |    2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

arch/arm/mach-mmp/aspenite.c +2 -2

index 1721c54..0629394 100644
@@ -151,7 +151,7 @@ static void __init common_init(void)
 MACHINE_START(ASPENITE, "PXA168-based Aspenite Development Platform")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = pxa168_init_irq,
 	.timer          = &pxa168_timer,
 	.init_machine   = common_init,

@@ -160,7 +160,7 @@ MACHINE_END
 MACHINE_START(ZYLONITE2, "PXA168-based Zylonite2 Development Platform")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = pxa168_init_irq,
 	.timer          = &pxa168_timer,
 	.init_machine   = common_init,

arch/arm/mach-mmp/avengers_lite.c +1 -1

index 2906c9e..69bcba1 100644
@@ -43,7 +43,7 @@ static void __init avengers_lite_init(void)
 MACHINE_START(AVENGERS_LITE, "PXA168 Avengers lite Development Platform")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = pxa168_init_irq,
 	.timer          = &pxa168_timer,
 	.init_machine   = avengers_lite_init,

arch/arm/mach-mmp/common.c +1 -1

index e1e66c1..3b29fa7 100644
@@ -31,7 +31,7 @@ static struct map_desc standard_io_desc[] __initdata = {
 	},
 };
 
-void __init pxa_map_io(void)
+void __init mmp_map_io(void)
 {
 	iotable_init(standard_io_desc, ARRAY_SIZE(standard_io_desc));
 }

arch/arm/mach-mmp/common.h +1 -1

index b4a0ba0..9696175 100644
@@ -14,4 +14,4 @@ extern void __init mmp2_init_icu(void);
 extern void __init mmp2_init_irq(void);
 
 extern void __init icu_init_irq(void);
-extern void __init pxa_map_io(void);
+extern void __init mmp_map_io(void);

arch/arm/mach-mmp/flint.c +1 -1

index e77bb0a..e4312d2 100644
@@ -115,7 +115,7 @@ static void __init flint_init(void)
 MACHINE_START(FLINT, "Flint Development Platform")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = mmp2_init_irq,
 	.timer          = &mmp2_timer,
 	.init_machine   = flint_init,

arch/arm/mach-mmp/jasper.c +1 -1

index 8e2b171..80c3e7a 100644
@@ -136,7 +136,7 @@ static void __init jasper_init(void)
 MACHINE_START(MARVELL_JASPER, "Jasper Development Platform")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = mmp2_init_irq,
 	.timer          = &mmp2_timer,
 	.init_machine   = jasper_init,

arch/arm/mach-mmp/tavorevb.c +1 -1

index b8b38aa..e81db74 100644
@@ -101,7 +101,7 @@ static void __init tavorevb_init(void)
 MACHINE_START(TAVOREVB, "PXA910 Evaluation Board (aka TavorEVB)")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = pxa910_init_irq,
 	.timer          = &pxa910_timer,
 	.init_machine   = tavorevb_init,

arch/arm/mach-mmp/ttc_dkb.c +1 -1

index ba3ce41..ee65e05 100644
@@ -124,7 +124,7 @@ static void __init ttc_dkb_init(void)
 MACHINE_START(TTC_DKB, "PXA910-based TTC_DKB Development Platform")
 	.phys_io        = APB_PHYS_BASE,
 	.io_pg_offst    = (APB_VIRT_BASE >> 18) & 0xfffc,
-	.map_io		= pxa_map_io,
+	.map_io		= mmp_map_io,
 	.init_irq       = pxa910_init_irq,
 	.timer          = &pxa910_timer,
 	.init_machine   = ttc_dkb_init,

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:59 UTC #7 lore raw

PATCH 7/9 mmp: move mmp2 specific timer code to mmp2.c

In reply to Eric Miao

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-mmp/mmp2.c |   21 +++++++++++++++++++++
 arch/arm/mach-mmp/time.c |   21 ---------------------
 2 files changed, 21 insertions(+), 21 deletions(-)

arch/arm/mach-mmp/mmp2.c +21 -0

index 7f5eb05..b3fddac 100644
@@ -17,6 +17,7 @@
 
 #include <asm/hardware/cache-tauros2.h>
 
+#include <asm/mach/time.h>
 #include <mach/addr-map.h>
 #include <mach/regs-apbc.h>
 #include <mach/regs-apmu.h>

@@ -158,6 +159,26 @@ static int __init mmp2_init(void)
 }
 postcore_initcall(mmp2_init);
 
+static void __init mmp2_timer_init(void)
+{
+	unsigned long clk_rst;
+
+	__raw_writel(APBC_APBCLK | APBC_RST, APBC_MMP2_TIMERS);
+
+	/*
+	 * enable bus/functional clock, enable 6.5MHz (divider 4),
+	 * release reset
+	 */
+	clk_rst = APBC_APBCLK | APBC_FNCLK | APBC_FNCLKSEL(1);
+	__raw_writel(clk_rst, APBC_MMP2_TIMERS);
+
+	timer_init(IRQ_MMP2_TIMER1);
+}
+
+struct sys_timer mmp2_timer = {
+	.init	= mmp2_timer_init,
+};
+
 /* on-chip devices */
 MMP2_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4030000, 0x30, 4, 5);
 MMP2_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4017000, 0x30, 20, 21);

arch/arm/mach-mmp/time.c +0 ~~-21~~

index cf75694..6652819 100644
@@ -200,24 +200,3 @@ void __init timer_init(int irq)
 	clocksource_register(&cksrc);
 	clockevents_register_device(&ckevt);
 }
-
-static void __init mmp2_timer_init(void)
-{
-	unsigned long clk_rst;
-
-	__raw_writel(APBC_APBCLK | APBC_RST, APBC_MMP2_TIMERS);
-
-	/*
-	 * enable bus/functional clock, enable 6.5MHz (divider 4),
-	 * release reset
-	 */
-	clk_rst = APBC_APBCLK | APBC_FNCLK | APBC_FNCLKSEL(1);
-	__raw_writel(clk_rst, APBC_MMP2_TIMERS);
-
-	timer_init(IRQ_MMP2_TIMER1);
-}
-
-struct sys_timer mmp2_timer = {
-	.init	= mmp2_timer_init,
-};
-

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:59 UTC #8 lore raw

PATCH 8/9 mmp: avoid devices.h being included multiple times

In reply to Eric Miao

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-mmp/include/mach/devices.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

arch/arm/mach-mmp/include/mach/devices.h +4 -0

index 1fa0a49..d0ec7da 100644
@@ -1,3 +1,6 @@
+#ifndef __MACH_DEVICE_H
+#define __MACH_DEVICE_H
+
 #include <linux/types.h>
 
 #define MAX_RESOURCE_DMA	2

@@ -47,3 +50,4 @@ struct pxa_device_desc mmp2_device_##_name __initdata = {		\
 }
 
 extern int pxa_register_device(struct pxa_device_desc *, void *, size_t);
+#endif /* __MACH_DEVICE_H */

Signature · 1 line

1.7.1

Eric Miao

author

2010-07-19 10:59 UTC #9 lore raw

PATCH 9/9 mmp: move declarations into SoC specific header file from common.h

In reply to Eric Miao

Signed-off-by Eric Miao <[email protected]>

---
 arch/arm/mach-mmp/common.h              |    9 ---------
 arch/arm/mach-mmp/include/mach/mmp2.h   |    7 +++++++
 arch/arm/mach-mmp/include/mach/pxa168.h |    5 +++++
 arch/arm/mach-mmp/include/mach/pxa910.h |    5 +++++
 arch/arm/mach-mmp/irq-mmp2.c            |    1 +
 arch/arm/mach-mmp/mmp2.c                |    1 +
 6 files changed, 19 insertions(+), 9 deletions(-)

arch/arm/mach-mmp/common.h +0 -9

index 9696175..ec8d65d 100644
@@ -3,15 +3,6 @@
 struct sys_timer;
 
 extern void timer_init(int irq);
-extern void mmp2_clear_pmic_int(void);
-
-extern struct sys_timer pxa168_timer;
-extern struct sys_timer pxa910_timer;
-extern struct sys_timer mmp2_timer;
-extern void __init pxa168_init_irq(void);
-extern void __init pxa910_init_irq(void);
-extern void __init mmp2_init_icu(void);
-extern void __init mmp2_init_irq(void);
 
 extern void __init icu_init_irq(void);
 extern void __init mmp_map_io(void);

arch/arm/mach-mmp/include/mach/mmp2.h +7 -0

index fec220b..dbba6e8 100644
@@ -1,6 +1,13 @@
 #ifndef __ASM_MACH_MMP2_H
 #define __ASM_MACH_MMP2_H
 
+struct sys_timer;
+
+extern struct sys_timer mmp2_timer;
+extern void __init mmp2_init_icu(void);
+extern void __init mmp2_init_irq(void);
+extern void mmp2_clear_pmic_int(void);
+
 #include <linux/i2c.h>
 #include <mach/devices.h>
 #include <plat/i2c.h>

arch/arm/mach-mmp/include/mach/pxa168.h +5 -0

index 3b2bd5d..27e1bc7 100644
@@ -1,6 +1,11 @@
 #ifndef __ASM_MACH_PXA168_H
 #define __ASM_MACH_PXA168_H
 
+struct sys_timer;
+
+extern struct sys_timer pxa168_timer;
+extern void __init pxa168_init_irq(void);
+
 #include <linux/i2c.h>
 #include <mach/devices.h>
 #include <plat/i2c.h>

arch/arm/mach-mmp/include/mach/pxa910.h +5 -0

index 4f0b4ec..f13c49d 100644
@@ -1,6 +1,11 @@
 #ifndef __ASM_MACH_PXA910_H
 #define __ASM_MACH_PXA910_H
 
+struct sys_timer;
+
+extern struct sys_timer pxa910_timer;
+extern void __init pxa910_init_irq(void);
+
 #include <linux/i2c.h>
 #include <mach/devices.h>
 #include <plat/i2c.h>

arch/arm/mach-mmp/irq-mmp2.c +1 -0

index cb18221..01342be 100644
@@ -16,6 +16,7 @@
 #include <linux/io.h>
 
 #include <mach/regs-icu.h>
+#include <mach/mmp2.h>
 
 #include "common.h"

arch/arm/mach-mmp/mmp2.c +1 -0

index b3fddac..daf3993 100644
@@ -27,6 +27,7 @@
 #include <mach/mfp.h>
 #include <mach/gpio.h>
 #include <mach/devices.h>
+#include <mach/mmp2.h>
 
 #include "common.h"
 #include "clock.h"

Signature · 1 line

1.7.1