Skip to contentSkip to conversation

input: fix uninitialized old_keycode oops in input_set_keycode

PATCH New Jarod Wilson 1 participant 1 message Jul 19, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: fix uninitialized old_keycode oops in input_set_keycode

Patch as suggested by Kyle McMartin, in response to Red Hat bugzilla 615707, filed against a rawhide kernel carrying ir-core enabling patches from the linuxtv staging/other tree. Fix is based on the similar logic in input_set_keycode_big, and is confirmed by the bz reporter.

---
 drivers/input/input.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/input.c +1 -0
index ce5d90d..0c71977 100644
@@ -900,6 +900,7 @@ int input_set_keycode(struct input_dev *dev,
 		if (retval)
 			goto out;
 
+		old_keycode = kt_entry.keycode;
 		kt_entry.keycode = keycode;
 
 		retval = dev->setkeycodebig(dev, &kt_entry);
Signature · 6 lines
1.7.1.1


-- 
Jarod Wilson
[email protected]