libmultipath: always allocate space for alias

PATCH New Hannes Reinecke 1 participant 1 message Jul 20, 2010 Device mapper

lore

Share & tools

lore

Hannes Reinecke

author

2010-07-20 08:10 UTC #0 lore raw

PATCH 1/1 libmultipath: always allocate space for alias

We should always allocating space for alias. This makes freeing up and allocation tracking far easier.

Signed-off-by Hannes Reinecke <[email protected]>

---
 libmultipath/propsel.c     |    6 +++---
 libmultipath/structs.c     |    4 +---
 libmultipath/structs_vec.c |   10 ++++++++--
 3 files changed, 12 insertions(+), 8 deletions(-)

libmultipath/propsel.c +3 -3

index ee4109e..3074ce1 100644
@@ -239,7 +239,7 @@ extern int
 select_alias (struct multipath * mp)
 {
 	if (mp->mpe && mp->mpe->alias)
-		mp->alias = mp->mpe->alias;
+		mp->alias = STRDUP(mp->mpe->alias);
 	else {
 		mp->alias = NULL;
 		if (conf->user_friendly_names) {

@@ -257,7 +257,7 @@ select_alias (struct multipath * mp)
 			}
 		}
 		if (mp->alias == NULL)
-			mp->alias = mp->wwid;
+			mp->alias = STRDUP(mp->wwid);
 	}
 
 	return 0;

@@ -472,7 +472,7 @@ select_pg_timeout(struct multipath *mp)
 		return 0;
 	}
 	mp->pg_timeout = PGTIMEOUT_UNDEF;
-	condlog(3, "pg_timeout = NONE (internal default)");
+	condlog(3, "%s: pg_timeout = NONE (internal default)", mp->alias);
 	return 0;
 }

libmultipath/structs.c +1 -3

index a4b86d2..82df680 100644
@@ -163,9 +163,7 @@ free_multipath (struct multipath * mpp, int free_paths)
 
 	free_multipath_attributes(mpp);
 
-	if (mpp->alias &&
-	    (!mpp->mpe || (mpp->mpe && mpp->alias != mpp->mpe->alias)) &&
-	    (mpp->wwid && mpp->alias != mpp->wwid)) {
+	if (mpp->alias) {
 		FREE(mpp->alias);
 		mpp->alias = NULL;
 	}

libmultipath/structs_vec.c +8 -2

index 699efa1..51c41e8 100644
@@ -335,8 +335,13 @@ retry:
 	condlog(3, "%s: discover", mpp->alias);
 
 	if (update_multipath_strings(mpp, vecs->pathvec)) {
-		char new_alias[WWID_SIZE];
+		char *new_alias;
 
+		new_alias = MALLOC(WWID_SIZE);
+		if (!new_alias) {
+			condlog(0, "%s: failed to allocate alias", mpp->alias);
+			goto out;
+		}
 		/*
 		 * detect an external rename of the multipath device
 		 */

@@ -344,7 +349,8 @@ retry:
 			condlog(3, "%s multipath mapped device name has "
 				"changed from %s to %s", mpp->wwid,
 				mpp->alias, new_alias);
-			strcpy(mpp->alias, new_alias);
+			FREE(mpp->alias);
+			mpp->alias = new_alias;
 
 			if (mpp->waiter)
 				strncpy(((struct event_thread *)mpp->waiter)->mapname,

Signature · 1 line

1.6.0.2