drm/i915: fix deadlock in fb teardown

PATCH New Jesse Barnes 1 participant 1 message Jul 20, 2010

Subsystems (2)

DRM drivers Intel i915

lore

Share & tools

lore

Jesse Barnes

author

2010-07-20 18:57 UTC #0 lore raw

PATCH 1/1 drm/i915: fix deadlock in fb teardown

At module unload time we'll tear down the fbdev state. We do so under the struct mutex, so we shouldn't try to use the unlocked variant of the GEM object unreference function or we may deadlock.

Signed-off-by Jesse Barnes <[email protected]>

drivers/gpu/drm/i915/intel_fb.c +1 -1

index c3c5052..866ad05 100644
@@ -236,7 +236,7 @@ int intel_fbdev_destroy(struct drm_device *dev,
 
 	drm_framebuffer_cleanup(&ifb->base);
 	if (ifb->obj)
-		drm_gem_object_unreference_unlocked(ifb->obj);
+		drm_gem_object_unreference(ifb->obj);
 
 	return 0;
 }