e1000e: Drop a useless statement
Subsystems (2)
PATCH 1/1 e1000e: Drop a useless statement
err is set again a few lines below.
Signed-off-by Jean Delvare <[email protected]>
Cc Auke Kok <[email protected]>
Cc Bruce Allan <[email protected]>
Cc Jesse Brandeburg <[email protected]>
---
I sent this patch to the e1000-devel list on June 8th, 2010, but didn't receive any answer:
http://sourceforge.net/mailarchive/forum.php?thread_name=201006081820.25381.jdelvare%40suse.de&forum_name=e1000-devel
drivers/net/e1000e/netdev.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/e1000e/netdev.c +0 -2
@@ -5557,8 +5557,6 @@ static int __devinit e1000_probe(structif (err) goto err_sw_init; - err = -EIO ; -memcpy (&hw->mac.ops, ei->mac_ops,sizeof (hw->mac.ops));memcpy (&hw->nvm.ops, ei->nvm_ops,sizeof (hw->nvm.ops));memcpy (&hw->phy.ops, ei->phy_ops,sizeof (hw->phy.ops));
Signature · 2 lines
Jean Delvare Suse L3
Quoted 27 lines · Jean Delvare
err is set again a few lines below.
Signed-off-by Jean Delvare <[email protected]>Cc Auke Kok <[email protected]>Cc Bruce Allan <[email protected]>Cc Jesse Brandeburg <[email protected]>---
I sent this patch to the e1000-devel list on June 8th, 2010, but didn't receive any answer:
http://sourceforge.net/mailarchive/forum.php?thread_name=201006081820.25381.jdelvare%40suse.de&forum_name=e1000-develdrivers/net/e1000e/netdev.c | 2 --
1 file changed, 2 deletions(-)drivers/net/e1000e/netdev.c +0
-3@@ -5557,8 +5557,6 @@ static int __devinit e1000_probe(struct if (err) goto err_sw_init; - err = -EIO; - memcpy(&hw->mac.ops, ei->mac_ops, sizeof(hw->mac.ops)); memcpy(&hw->nvm.ops, ei->nvm_ops, sizeof(hw->nvm.ops)); memcpy(&hw->phy.ops, ei->phy_ops, sizeof(hw->phy.ops)); --
Quoted 2 lines
Jean Delvare
Suse L3
Thanks Jean, sorry for the delayed response. I have added the patch to my queue.
Signature · 2 lines
Cheers, Jeff