Skip to contentSkip to conversation

Add support for Vista Silicon Visstrim_m10 board [v5].

PATCH New Javier Martin 4 participants 4 messages Jul 22, 2010 – Jul 23, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Javier Martin

author
#0 lore raw

PATCH 1/1 Add support for Vista Silicon Visstrim_m10 board [v5].

Vista Silicon Visstrim_m10 i.MX27 based board is used as multimedia streaming server, access control and other custom applications.

Include files in correct order and use <linux/gpio.h> instead of <mach/gpio.h>.

Signed-off-by Javier Martin <[email protected]>
---
 arch/arm/mach-imx/Kconfig                   |    9 +
 arch/arm/mach-imx/Makefile                  |    1 +
 arch/arm/mach-imx/mach-imx27_visstrim_m10.c |  266 +++++++++++++++++++++++++++
 3 files changed, 276 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-imx/mach-imx27_visstrim_m10.c
arch/arm/mach-imx/Kconfig +9 -0
index c5c0369..19ed16d 100644
@@ -163,6 +163,15 @@ config MACH_MX27_3DS
 	  Include support for MX27PDK platform. This includes specific
 	  configurations for the board and its peripherals.
 
+config MACH_IMX27_VISSTRIM_M10
+	bool "Vista Silicon i.MX27 Visstrim_m10"
+	select IMX_HAVE_PLATFORM_IMX_I2C
+	select IMX_HAVE_PLATFORM_IMX_UART
+	help
+	  Include support for Visstrim_m10 platform and its different variants.
+	  This includes specific configurations for the board and its
+	  peripherals.
+
 config MACH_IMX27LITE
 	bool "LogicPD MX27 LITEKIT platform"
 	select IMX_HAVE_PLATFORM_IMX_UART
arch/arm/mach-imx/Makefile +1 -0
index 46a9fdf..5582692 100644
@@ -27,6 +27,7 @@ obj-$(CONFIG_MACH_PCM038) += mach-pcm038.o
 obj-$(CONFIG_MACH_PCM970_BASEBOARD) += pcm970-baseboard.o
 obj-$(CONFIG_MACH_MX27_3DS) += mach-mx27_3ds.o
 obj-$(CONFIG_MACH_IMX27LITE) += mach-imx27lite.o
+obj-$(CONFIG_MACH_IMX27_VISSTRIM_M10) += mach-imx27_visstrim_m10.o
 obj-$(CONFIG_MACH_CPUIMX27) += mach-cpuimx27.o
 obj-$(CONFIG_MACH_EUKREA_MBIMX27_BASEBOARD) += eukrea_mbimx27-baseboard.o
 obj-$(CONFIG_MACH_PCA100) += mach-pca100.o
arch/arm/mach-imx/mach-imx27_visstrim_m10.c new file +266 -0

266 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 Add support for Vista Silicon Visstrim_m10 board [v5].

Hi Javier,

Quoted 14 lines · Javier Martin

Vista Silicon Visstrim_m10 i.MX27 based board is used as multimedia streaming server, access control and other custom applications.

Include files in correct order and use <linux/gpio.h> instead of <mach/gpio.h>.

Signed-off-by Javier Martin <[email protected]>
---
 arch/arm/mach-imx/Kconfig                   |    9 +
 arch/arm/mach-imx/Makefile                  |    1 +
 arch/arm/mach-imx/mach-imx27_visstrim_m10.c |  266 +++++++++++++++++++++++++++
 3 files changed, 276 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-imx/mach-imx27_visstrim_m10.c

[snip]

Quoted 19 lines

new file mode 100644
index 0000000..f18b9ed

arch/arm/mach-imx/mach-imx27_visstrim_m10.c new file +14 -0
@@ -0,0 +1,266 @@
+/*
+ * mach-imx27_visstrim_m10.c
+ *
+ * Copyright 2010  Javier Martin <[email protected]>
+ *
+ * Based on mach-pcm038.c, mach-pca100.c, mach-mx27ads.c and others.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of

arch/arm/mach-imx/mach-imx27_visstrim_m10.c line 24

Quoted 10 lines
arch/arm/mach-imx/mach-imx27_visstrim_m10.c new file +10 -0
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#define pr_fmt(fmt) "visstrim_m10: " fmt

This isn't used anywhere.

Quoted 6 lines
arch/arm/mach-imx/mach-imx27_visstrim_m10.c new file +6 -0
+#include <linux/platform_device.h>
+#include <linux/mtd/physmap.h>
+#include <linux/i2c.h>
+#include <linux/i2c/pca953x.h>
+#include <linux/gpio_keys.h>
+#include <linux/input.h>

arch/arm/mach-imx/mach-imx27_visstrim_m10.c line 41

Quoted 10 lines
arch/arm/mach-imx/mach-imx27_visstrim_m10.c new file +10 -0
+#include <linux/gpio.h>
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach/time.h>
+#include <mach/common.h>
+#include <mach/mmc.h>
+#include <mach/iomux.h>
+#include <mach/mxc_ehci.h>
+
+

One empty line should be enough.

arch/arm/mach-imx/mach-imx27_visstrim_m10.c line 49

Quoted 8 lines
arch/arm/mach-imx/mach-imx27_visstrim_m10.c new file +8 -0
+#include "devices-imx27.h"
+#include "devices.h"
+
+#define OTG_PHY_CS_GPIO (GPIO_PORTF + 17)
+#define SDHC1_IRQ IRQ_GPIOB(25)
+
+
+

Ditto.

[snip]

baruch

Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 Add support for Vista Silicon Visstrim_m10 board [v5].

Quoted 6 lines · Baruch Siach

Hi Javier,

Quoted 1 line · Javier Martin

+#define pr_fmt(fmt) "visstrim_m10: " fmt

This isn't used anywhere.

Please read the earlier review(s).

#3 lore raw

PATCH 1/1 Add support for Vista Silicon Visstrim_m10 board [v5].

In reply to Javier Martin

On Thu, 2010-07-22 at 12:48 +0200, Javier Martin wrote:
[]

Quoted 1 line

+#define pr_fmt(fmt) "visstrim_m10: " fmt

I think it'd be better to use:

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

cheers, Joe