Skip to contentSkip to conversation

caif: precedence bug

PATCH Applied Dan Carpenter 2 participants 2 messages Jul 22, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 caif: precedence bug

Negate has precedence over comparison so the original assert only checked that "rfml->fragment_size" was larger than 1 or 0.

net/caif/cfrfml.c +1 -1
index 4b04d25..eb16020 100644
@@ -193,7 +193,7 @@ out:
 
 static int cfrfml_transmit_segment(struct cfrfml *rfml, struct cfpkt *pkt)
 {
-	caif_assert(!cfpkt_getlen(pkt) < rfml->fragment_size);
+	caif_assert(cfpkt_getlen(pkt) >= rfml->fragment_size);
 
 	/* Add info for MUX-layer to route the packet out. */
 	cfpkt_info(pkt)->channel_id = rfml->serv.layer.id;