Skip to contentSkip to conversation

mbimxsd baseboards : remove unecessary include

PATCH New Eric Bénard 2 participants 5 messages Jul 23, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Eric Bénard

author
#0 lore raw

PATCH 1/3 mbimxsd baseboards : remove unecessary include

Signed-off-by Eric B?nard <[email protected]>
---
 arch/arm/mach-mx25/eukrea_mbimxsd-baseboard.c |    1 -
 arch/arm/mach-mx3/eukrea_mbimxsd-baseboard.c  |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-mx25/eukrea_mbimxsd-baseboard.c +0 -1
index f07b1f9..91931dc 100644
@@ -26,7 +26,6 @@
 #include <linux/input.h>
 #include <video/platform_lcd.h>
 
-#include <mach/board-eukrea_cpuimx25.h>
 #include <mach/hardware.h>
 #include <mach/iomux-mx25.h>
 #include <mach/common.h>
arch/arm/mach-mx3/eukrea_mbimxsd-baseboard.c +0 -1
index 368a603..1dc5004 100644
@@ -36,7 +36,6 @@
 #include <asm/mach/time.h>
 #include <asm/mach/map.h>
 
-#include <mach/board-eukrea_cpuimx35.h>
 #include <mach/hardware.h>
 #include <mach/common.h>
 #include <mach/imx-uart.h>
Signature · 1 line
1.6.3.3
author
#1 lore raw

PATCH 2/3 Fix KConfig warning

This patch fixes the following Kconfig warning :
"arch/arm/mach-mx25/Kconfig:18:warning: choice value used outside its choice group

Signed-off-by Eric B?nard <[email protected]>
---
 arch/arm/mach-mx25/Kconfig  |    4 ++--
 arch/arm/mach-mx25/Makefile |    2 +-
 arch/arm/mach-mx3/Kconfig   |    4 ++--
 arch/arm/mach-mx3/Makefile  |    2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/mach-mx25/Kconfig +2 -2
index 67e0b54..c71a7bc 100644
@@ -17,9 +17,9 @@ config MACH_EUKREA_CPUIMX25
 choice
 	prompt "Baseboard"
 	depends on MACH_EUKREA_CPUIMX25
-	default MACH_EUKREA_MBIMXSD_BASEBOARD
+	default MACH_EUKREA_MBIMXSD25_BASEBOARD
 
-config MACH_EUKREA_MBIMXSD_BASEBOARD
+config MACH_EUKREA_MBIMXSD25_BASEBOARD
 	prompt "Eukrea MBIMXSD development board"
 	bool
 	help
arch/arm/mach-mx25/Makefile +1 -1
index 87ffb9c..d9e46ce 100644
@@ -2,4 +2,4 @@ obj-y				:= mm.o devices.o
 obj-$(CONFIG_ARCH_MX25)		+= clock.o
 obj-$(CONFIG_MACH_MX25_3DS)	+= mach-mx25_3ds.o
 obj-$(CONFIG_MACH_EUKREA_CPUIMX25)		+= mach-cpuimx25.o
-obj-$(CONFIG_MACH_EUKREA_MBIMXSD_BASEBOARD)	+= eukrea_mbimxsd-baseboard.o
+obj-$(CONFIG_MACH_EUKREA_MBIMXSD25_BASEBOARD)	+= eukrea_mbimxsd-baseboard.o
arch/arm/mach-mx3/Kconfig +2 -2
index e063657..b73a9fd 100644
@@ -166,9 +166,9 @@ config MACH_EUKREA_CPUIMX35
 choice
 	prompt "Baseboard"
 	depends on MACH_EUKREA_CPUIMX35
-	default MACH_EUKREA_MBIMXSD_BASEBOARD
+	default MACH_EUKREA_MBIMXSD35_BASEBOARD
 
-config MACH_EUKREA_MBIMXSD_BASEBOARD
+config MACH_EUKREA_MBIMXSD35_BASEBOARD
 	prompt "Eukrea MBIMXSD development board"
 	bool
 	help
arch/arm/mach-mx3/Makefile +1 -1
index 54bc935..2bd7bec 100644
@@ -25,4 +25,4 @@ obj-$(CONFIG_MACH_ARMADILLO5X0) += mach-armadillo5x0.o
 obj-$(CONFIG_MACH_MX35_3DS)	+= mach-mx35_3ds.o
 obj-$(CONFIG_MACH_KZM_ARM11_01)	+= mach-kzm_arm11_01.o
 obj-$(CONFIG_MACH_EUKREA_CPUIMX35)	+= mach-cpuimx35.o
-obj-$(CONFIG_MACH_EUKREA_MBIMXSD_BASEBOARD)	+= eukrea_mbimxsd-baseboard.o
+obj-$(CONFIG_MACH_EUKREA_MBIMXSD35_BASEBOARD)	+= eukrea_mbimxsd-baseboard.o
Signature · 1 line
1.6.3.3
author
#2 lore raw

PATCH 3/3 eukrea-baseboards: merge includes in one file

as per suggested by Sascha

Signed-off-by Eric B?nard <[email protected]>
---
 arch/arm/mach-imx/mach-cpuimx27.c                  |    2 +-
 arch/arm/mach-mx25/mach-cpuimx25.c                 |    2 +-
 arch/arm/mach-mx3/mach-cpuimx35.c                  |    2 +-
 .../plat-mxc/include/mach/board-eukrea_cpuimx25.h  |   40 -----------------
 .../plat-mxc/include/mach/board-eukrea_cpuimx27.h  |   40 -----------------
 .../plat-mxc/include/mach/board-eukrea_cpuimx35.h  |   40 -----------------
 arch/arm/plat-mxc/include/mach/eukrea-baseboards.h |   45 ++++++++++++++++++++
 7 files changed, 48 insertions(+), 123 deletions(-)
 delete mode 100644 arch/arm/plat-mxc/include/mach/board-eukrea_cpuimx25.h
 delete mode 100644 arch/arm/plat-mxc/include/mach/board-eukrea_cpuimx27.h
 delete mode 100644 arch/arm/plat-mxc/include/mach/board-eukrea_cpuimx35.h
 create mode 100644 arch/arm/plat-mxc/include/mach/eukrea-baseboards.h
arch/arm/mach-imx/mach-cpuimx27.c +1 -1
index 2a13544..575ff1a 100644
@@ -35,7 +35,7 @@
 #include <asm/mach/time.h>
 #include <asm/mach/map.h>
 
-#include <mach/board-eukrea_cpuimx27.h>
+#include <mach/eukrea-baseboards.h>
 #include <mach/common.h>
 #include <mach/hardware.h>
 #include <mach/iomux-mx27.h>
arch/arm/mach-mx25/mach-cpuimx25.c +1 -1
index d39f9cc..56b2e26 100644
@@ -29,7 +29,7 @@
 #include <linux/usb/ulpi.h>
 #include <linux/fsl_devices.h>
 
-#include <mach/board-eukrea_cpuimx25.h>
+#include <mach/eukrea-baseboards.h>
 #include <mach/hardware.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
arch/arm/mach-mx3/mach-cpuimx35.c +1 -1
index 4f6146d..63f970f 100644
@@ -37,7 +37,7 @@
 #include <asm/mach/time.h>
 #include <asm/mach/map.h>
 
-#include <mach/board-eukrea_cpuimx35.h>
+#include <mach/eukrea-baseboards.h>
 #include <mach/hardware.h>
 #include <mach/common.h>
 #include <mach/iomux-mx35.h>
arch/arm/plat-mxc/include/mach/board-eukrea_cpuimx25.h deleted +0 -40
deleted file mode 100644
index 5c9901e..0000000
@@ -1,40 +0,0 @@
-/*
- * Copyright (C) 2010 Eric Benard - eric at eukrea.com
- *
- * Based on board-pcm038.h which is :
- * Copyright (C) 2008 Juergen Beisert (kernel at pengutronix.de)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
- * MA 02110-1301, USA.
- */
-
-#ifndef __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX25_H__
-#define __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX25_H__
-
-#ifndef __ASSEMBLY__
-/*
- * This CPU module needs a baseboard to work. After basic initializing
- * its own devices, it calls baseboard's init function.
- * TODO: Add your own baseboard init function and call it from
- * inside eukrea_cpuimx25_init().
- *
- * This example here is for the development board. Refer
- * eukrea_mbimx25-baseboard.c
- */
-
-extern void eukrea_mbimxsd_baseboard_init(void);
-
-#endif
-
-#endif /* __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX25_H__ */
arch/arm/plat-mxc/include/mach/board-eukrea_cpuimx27.h deleted +0 -40
deleted file mode 100644
index 45b2fb8..0000000
@@ -1,40 +0,0 @@
-/*
- * Copyright (C) 2009 Eric Benard - eric at eukrea.com
- *
- * Based on board-pcm038.h which is :
- * Copyright (C) 2008 Juergen Beisert (kernel at pengutronix.de)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
- * MA 02110-1301, USA.
- */
-
-#ifndef __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX27_H__
-#define __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX27_H__
-
-#ifndef __ASSEMBLY__
-/*
- * This CPU module needs a baseboard to work. After basic initializing
- * its own devices, it calls the baseboard's init function.
- * TODO: Add your own baseboard init function and call it from
- * inside eukrea_cpuimx27_init().
- *
- * This example here is for the development board. Refer
- * eukrea_mbimx27-baseboard.c
- */
-
-extern void eukrea_mbimx27_baseboard_init(void);
-
-#endif
-
-#endif /* __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX27_H__ */
arch/arm/plat-mxc/include/mach/board-eukrea_cpuimx35.h deleted +0 -40
deleted file mode 100644
index 116eee7..0000000
@@ -1,40 +0,0 @@
-/*
- * Copyright (C) 2010 Eric Benard - eric at eukrea.com
- *
- * Based on board-pcm038.h which is :
- * Copyright (C) 2008 Juergen Beisert (kernel at pengutronix.de)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
- * MA 02110-1301, USA.
- */
-
-#ifndef __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX35_H__
-#define __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX35_H__
-
-#ifndef __ASSEMBLY__
-/*
- * This CPU module needs a baseboard to work. After basic initializing
- * its own devices, it calls baseboard's init function.
- * TODO: Add your own baseboard init function and call it from
- * inside eukrea_cpuimx25_init().
- *
- * This example here is for the development board. Refer
- * eukrea_mbimx25-baseboard.c
- */
-
-extern void eukrea_mbimxsd_baseboard_init(void);
-
-#endif
-
-#endif /* __ASM_ARCH_MXC_BOARD_EUKREA_CPUIMX35_H__ */
arch/arm/plat-mxc/include/mach/eukrea-baseboards.h new file +45 -0

45 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#3 lore raw

PATCH 1/3 mbimxsd baseboards : remove unecessary include

In reply to Eric Bénard

Hello,

Quoted 6 lines · Eric B?nard
Signed-off-by Eric B?nard <[email protected]>
---
 arch/arm/mach-mx25/eukrea_mbimxsd-baseboard.c |    1 -
 arch/arm/mach-mx3/eukrea_mbimxsd-baseboard.c  |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

Ack for all three patches. I would suggest to include 2/3 before .35.

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
author
#4 lore raw

PATCH 1/3 mbimxsd baseboards : remove unecessary include

Hi Uwe,

Le 23/07/2010 15:11, Uwe Kleine-K?nig a ?crit :

Quoted 2 lines

Ack for all three patches. I would suggest to include 2/3 before .35.

it's not necessary for .35 as the boards are only in the imx-for-2.6.36 branch.

Eric