Skip to contentSkip to conversation

install udev rules into rules.d

PATCH In review Olaf Hering 2 participants 3 messages Jul 23, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 install udev rules into rules.d

Install rules straight into /etc/udev/rules.d
udev version 029 since mid 2004 uses this directory already.

---
 tools/hotplug/Linux/Makefile |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/hotplug/Linux/Makefile +1 -2
@@ -101,8 +101,7 @@ install-udev:
 		$(INSTALL_DIR) $(DESTDIR)$(UDEV_RULES_DIR)/rules.d
 	set -e; for i in $(UDEV_RULES); \
 	    do \
-	    $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \
-	    ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
+	    $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
 	done
 
 .PHONY: clean
#1 lore raw

Olaf Hering writes ("[Xen-devel] [PATCH] install udev rules into rules.d"):

tools/hotplug/Linux/Makefile install-udev: · line 104

Quoted 3 lines
tools/hotplug/Linux/Makefile +1 -2
-	    $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \
-	    ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
+	    $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \

What will this do if run on a system which already has the symlink arrangement from the previous versions of Xen ? Perhaps some kind of fixing up is necessary.

Ian.

#2 lore raw
Quoted 8 lines · Ian Jackson

Olaf Hering writes ("[Xen-devel] [PATCH] install udev rules into rules.d"):

tools/hotplug/Linux/Makefile install-udev: · line 104

Quoted 3 lines
tools/hotplug/Linux/Makefile +1 -2
-	    $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \
-	    ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
+	    $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \

What will this do if run on a system which already has the symlink arrangement from the previous versions of Xen ? Perhaps some kind of fixing up is necessary.

I tried strace -f -o x -s 123 install a b, and b was unlinked first. So it appears that the patch above is save.
Packing systems get this symlink-to-file thing right as well.

Olaf