remove Default-Enabled from LSB header
PATCH 1/1 remove Default-Enabled from LSB header
Default-Enabled: is not a LSB keyword.
Move it out of the LSB section to avoid an openSuSE buildcheck warning.
---
It may be removed altogether, even google has no hits besides the old Debian bug #458502
tools/hotplug/Linux/init.d/xencommons | 2 +- tools/hotplug/Linux/init.d/xend | 2 +- tools/hotplug/Linux/init.d/xendomains | 2 +- tools/xenballoon/xenballoond.init | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
tools/hotplug/Linux/init.d/xencommons +1 -1
@@ -14,10 +14,10 @@ # Should-Stop: # Default-Start: 3 4 5 # Default-Stop: 1 -# Default-Enabled: yes # Short-Description: Start/stop xenstored and xenconsoled # Description: Starts and stops the daemons neeeded for xl/xend ### END INIT INFO +# Default-Enabled: yes test -f /etc/sysconfig/xencommons && . /etc/sysconfig/xencommons
tools/hotplug/Linux/init.d/xend +1 -1
@@ -14,10 +14,10 @@ # Should-Stop: # Default-Start: 3 4 5 # Default-Stop: 0 1 2 6 -# Default-Enabled: yes # Short-Description: Start/stop xend # Description: Starts and stops the Xen control daemon. ### END INIT INFO +# Default-Enabled: yes shopt -s extglob
tools/hotplug/Linux/init.d/xendomains +1 -1
@@ -22,11 +22,11 @@ # Should-Stop: # Default-Start: 3 4 5 # Default-Stop: 0 1 2 6 -# Default-Enabled: yes # Short-Description: Start/stop secondary xen domains # Description: Start / stop domains automatically when domain 0 # boots / shuts down. ### END INIT INFO +# Default-Enabled: yes CMD=xm $CMD list &> /dev/null
tools/xenballoon/xenballoond.init +1 -1
@@ -16,10 +16,10 @@ # Should-Stop: # Default-Start: 3 4 5 # Default-Stop: 0 1 2 6 -# Default-Enabled: yes # Short-Description: Start/stop xend # Description: Starts and stops the Xen ballooning daemon. ### END INIT INFO +# Default-Enabled: yes # Source function library . /etc/init.d/functions
Olaf Hering writes ("[Xen-devel] [PATCH] remove Default-Enabled from LSB header"):
Quoted 2 lines
Default-Enabled: is not a LSB keyword.
Move it out of the LSB section to avoid an openSuSE buildcheck warning.
I'm pretty sure it was put there for a reason by the people who added these files. If we move it out of the INIT INFO section it's probably going to stop working.
Is it actually a breach of the LSB spec to include nonstandard keywords ?
Ian.
Quoted 7 lines · Ian Jackson
Olaf Hering writes ("[Xen-devel] [PATCH] remove Default-Enabled from LSB header"):
Quoted 2 lines
Default-Enabled: is not a LSB keyword.
Move it out of the LSB section to avoid an openSuSE buildcheck warning.I'm pretty sure it was put there for a reason by the people who added these files. If we move it out of the INIT INFO section it's probably going to stop working.
Its not clear what the intention was, LSB does not mention this keyword. Google has some hits about X-UnitedLinux-Default-Enabled: which implies what someone tried to get rid of the vendor part from this old string from end of 2002.
I'm sure nothing will break if the lines disappear.
Quoted 2 lines
Is it actually a breach of the LSB spec to include nonstandard keywords ?
I havent checked if LSB forbids it. Most likely the tools should tolerate unknown keywords.
Olaf
Olaf Hering writes ("Re: [Xen-devel] [PATCH] remove Default-Enabled from LSB header"):
Quoted 4 lines
Its not clear what the intention was, LSB does not mention this keyword. Google has some hits about X-UnitedLinux-Default-Enabled: which implies what someone tried to get rid of the vendor part from this old string from end of 2002.
Thanks for investigating.
Quoted 1 line
I'm sure nothing will break if the lines disappear.
OK, right, I'll apply your patch.
Ian.