Skip to contentSkip to conversation

cyber2000fb: fix machine hang on module load

PATCH Superseded Ondrej Zary 1 participant 1 message Jul 25, 2010 Framebuffer layer

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cyber2000fb: fix machine hang on module load

Hello,
I was testing two CyberPro 2000 based PCI cards on x86 and the machine always hanged completely when the cyber2000fb module was loaded. It seems that the card hangs when some registers are accessed too quickly after writing RAMDAC control register. With this patch, both card work.

Add delay after RAMDAC control register write to prevent hangs on module load.

drivers/video/cyber2000fb.c +1 -0
@@ -436,6 +436,7 @@ static void cyber2000fb_write_ramdac_ctr
 	cyber2000fb_writeb(i | 4, 0x3cf, cfb);
 	cyber2000fb_writeb(val, 0x3c6, cfb);
 	cyber2000fb_writeb(i, 0x3cf, cfb);
+	udelay(1);
 }
 
 static void cyber2000fb_set_timing(struct cfb_info *cfb, struct par_info *hw)
Signature · 1 line
Ondrej Zary